Make WordPress Core

Opened 3 months ago

Closed 4 weeks ago

Last modified 2 weeks ago

#61186 closed defect (bug) (fixed)

Twenty Nineteen: Apply center alignment to Archives and Categories List blocks in the editor

Reported by: pranitdugad's profile pranitdugad Owned by: karmatosed's profile karmatosed
Milestone: 6.7 Priority: normal
Severity: minor Version: 5.0
Component: Bundled Theme Keywords: has-patch commit
Focuses: ui, css Cc:

Description

Twenty Nineteen: Archive Block Alignment is set to centre and it's not working for centre alignment only in the backend.While on frontend its shows centre aligned block . Below is video for the same.

Video: https://jmp.sh/AQV9wZOk

Change History (9)

#1 @karmatosed
3 months ago

  • Keywords needs-patch added
  • Milestone changed from Awaiting Review to Future Release

It isn't that this doesn't centre align for me. What happens is that you see it central on the front, however due to variations in not having editor styles it seems to not do for the editor itself.

I tried to do a few other themes just incase this was a block issue and can confirm it is in fact a theme issue.

This ticket was mentioned in PR #6548 on WordPress/wordpress-develop by @sabernhardt.


3 months ago
#2

  • Keywords has-patch added; needs-patch removed

When users select center alignment for Archives or Categories List blocks, this would make the editor style match the text alignment used on the front end.

Trac 61186

#3 @sabernhardt
3 months ago

  • Focuses css added
  • Summary changed from Twenty Nineteen: Archive Block Alignment is not working in backend to Twenty Nineteen: Apply center alignment to Archives and Categories List blocks in the editor
  • Version set to 5.0

PR 684 centered text on the front end for Archives and Categories (List) blocks, but it did not include editor styles to match the front.

Related: #56537 might center text for the Latest Posts block, which could result in a different patch for all three blocks together in the editor.

@sabernhardt commented on PR #6548:


3 months ago
#4

Thanks for testing. I did not have the editor wide enough to notice the difference clearly.

However, the block alignment is actually correct for these blocks but not for the title, Paragraph blocks, etc. The front end centers .entry-content according to the page, and blocks within there align to the (left) side. The iframe editor aligns (most) blocks to the center of the canvas. Fixing that would belong on a separate ticket to test many more blocks and situations (possibly repurposing 53872, though a new ticket could be more appropriate).

#5 @karmatosed
5 weeks ago

  • Owner set to karmatosed
  • Status changed from new to assigned

I am going to assign this to myself to test in order to decide what to do next, thanks everyone.

#6 @karmatosed
5 weeks ago

  • Keywords needs-testing added

#7 @karmatosed
4 weeks ago

  • Keywords commit added

#8 @karmatosed
4 weeks ago

  • Resolution set to fixed
  • Status changed from assigned to closed

WordPress commit r58627 fixed this so closing.

#9 @sabernhardt
2 weeks ago

  • Keywords needs-testing removed
  • Milestone changed from Future Release to 6.7
Note: See TracTickets for help on using tickets.