Twenty Seventeen: Button block font weight does not change when using block Appearance setting

[pranitdugad]

Hello,
I have reviewed the "Button block" and found that its appearance is not changing when we are trying to change button appearance using block setting.
Here, I have attached its video.

Issue: ​https://jmp.sh/361cqMJI

Environment info:

WordPress version: WordPress 6.5 running,
Theme: Twenty Seventeen
Browser: Google Chrome
Device: MacBook Air M1
OS: macOS 14.4.1 (23E224
Thanks,

[pranitdugad]

After applying this patch , this issue is resolved

[sabernhardt]

Removing the default font-weight would change the appearance for (almost) everyone's existing blocks.

Related: #58991 (and others mentioned there)

[shailu25]

Patch Added

[shailu25]

Updated Patch as per suggested in above comment.

• In Button block if no font-weight is selected, it will take default font-weight.
• In Button block if font-weight is selected, then it will add selected font-weight.

[karmatosed]

Moving to the next release to get testing with a hope this could be considered.

[hmbashar]

Everything is fine from my end, there is no need to apply any patches.

Here is my Environment

• WordPress: 6.6-alpha-57778-src
• PHP: 8.3.7
• Server: nginx/1.25.4
• Database: mysqli (Server: 8.3.0 / Client: mysqlnd 8.3.7)
• Browser: Chrome 125.0.0.0
• OS: macOS
• Theme: Twenty Seventeen 3.6
• MU Plugins: None activated
• Plugins:
  • FakerPress 0.6.6
  • Test Reports 1.1.0

[karmatosed]

It looks like in testing this has been shown to not be an issue anymore - if that is the case let's look to close this and move on from here. If we still have as an issue we absolutely can look to patch.

[karmatosed]

As recommended I am going to close this now, thank you.

[sabernhardt]

With 6.6-beta3-58441, the links for Button and Buttons blocks still have a font-weight of 800 when someone uses the Appearance block setting to try changing the weight.

60937.diff​ correctly would make the links inherit a custom weight from the block. However:

1. The spaces for indentation should be replaced with tabs (possibly during commit).
2. The Appearance weight selections are somewhat limited because the theme only has the 300, 400, 600 and 800 weights for Libre Franklin.

[sabernhardt]

before patch, in editor (iframe)

[sabernhardt]

before patch, front end

[sabernhardt]

with patch applied, in editor (iframe)

[sabernhardt]

with patch applied, on front end

[karmatosed]

Thank you for your testing @sabernhardt for me I do think that over having this done in commit as there are a few things I would love to have a patch refresh on this so we can test with everything. We do have time as bundled themes are being packaged separate and we can keep committing until RC, then it will just go to the right version - which is great.

[shailu25]

Patch Refreshed

[shailu25]

@karmatosed I have refreshed the patch with Latest Trunk.

[karmatosed]

@shailu25 just confirming did you also do this as I don't see it:

The spaces for indentation should be replaced with tabs (possibly during commit).

[shailu25]

@karmatosed I have added tabs instead of space in Latest patch 60937.2

[karmatosed]

Assigning to myself for testing.

[karmatosed]

In 58584:

Twenty Seventeen: Fixes button block font weight not changing.

The button block appearance was not changing when using settings. This resolves that using inherit.

Props pranitdugad, sabernhardt, shailu25, hmbashar.
Fixes #60937.