Changeset 25268

Timestamp:

Apr 15, 2021, 7:19:27 PM (3 years ago)

Author:

Silier

Message:

Check for replay compatibility when opening summary screen

Summary screen and mainly its statistics can be influenced by mod as much as replay itself with mod removing or adding classes and trackers to the game.
Summary screen allows to replay the match without checking compatibility, that is fine I think if it is prevented to see summary of incompatible replay in a first place.

Therefore this is adding compatibility check for opening summary of replay.

Differential revision: D3799
Fixes: #6119
Tested by: @Langbart

File:

• ps/trunk/binaries/data/mods/public/gui/replaymenu/replay_actions.js (modified) (2 diffs)

ps/trunk/binaries/data/mods/public/gui/replaymenu/replay_actions.js

@@ -102 +102 @@
 
 /**
- * Opens the summary screen of the given replay, if its data was found in that directory.
+ * Opens the summary screen of the given replay, if its data was found in that directory.
  */
 function showReplaySummary()
 {
-    var selected = Engine.GetGUIObjectByName("replaySelection").selected;
+     selected = Engine.GetGUIObjectByName("replaySelection").selected;
     if (selected == -1)
         return;
 
+
+
+
+
+
+
+
+
+
     // Load summary screen data from the selected replay directory
-    let simData = Engine.GetReplayMetadata(g_ReplaysFiltered[selected].directory);
+    let simData = Engine.GetReplayMetadata(directory);
 
     if (!simData)
@@ -124 +133 @@
             "dialog": false,
             "isReplay": true,
-            "replayDirectory": g_ReplaysFiltered[selected].directory,
-            "replaySelectionData": createReplaySelectionData(g_ReplaysFiltered[selected].directory),
+            "replayDirectory": directory,
+            "replaySelectionData": createReplaySelectionData(directory),
             "summarySelection": g_SummarySelection
         }