[QA only] Wikilove is not dark mode friendly
Closed, ResolvedPublic0 Estimated Story PointsBUG REPORT
Actions

Assigned To

Authored By

	Jdlrobson
	Jun 17 2024, 10:04 PM

Description

Steps to replicate the issue (include links if applicable):

Visit a user page in dark mode e.g. https://en.wikipedia.beta.wmflabs.org/wiki/User:Edtadros-beta1
Click the <3 symbol

What happens?:

What should have happened instead?:
Should be accessible

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):
Easiest solution here would be to add notheme class to the overlay.

QA Results - PROD

AC	Status	Details
1	✅	T367824#9983441

Details

	Subject	Repo	Branch	Lines +/-
	Force light theme in Wikilove overlay	mediawiki/extensions/WikiLove	master	+1 -1

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		ovasileva	T366364 Enable night theme on user pages
		Resolved	BUG REPORT	ovasileva	T367824 [QA only] Wikilove is not dark mode friendly

Event Timeline

Jdlrobson created this task.Jun 17 2024, 10:04 PM

Restricted Application added a project: Growth-Team. · View Herald TranscriptJun 17 2024, 10:04 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Jdlrobson mentioned this in T365383: [Spike] QA outcome of OOUI work .Jun 17 2024, 10:19 PM

Jdlrobson added a parent task: T366364: Enable night theme on user pages.Jun 18 2024, 12:57 AM

Jdlrobson moved this task from Backlog to Excluded experiences on the FY2023-24-WE 2.1 Typography and palette customizations board.Jun 18 2024, 3:59 PM

Change #1048062 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/WikiLove@master] Force light theme in Wikilove overlay

https://gerrit.wikimedia.org/r/1048062

gerritbot added a project: Patch-For-Review.Jun 20 2024, 6:59 PM

Change #1048062 merged by jenkins-bot:

[mediawiki/extensions/WikiLove@master] Force light theme in Wikilove overlay

https://gerrit.wikimedia.org/r/1048062

Maintenance_bot removed a project: Patch-For-Review.Jun 20 2024, 9:30 PM

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.11; 2024-06-25).Jun 20 2024, 10:00 PM

Jdlrobson renamed this task from Wikilove is not dark mode friendly to [QA only] Wikilove is not dark mode friendly.Jun 20 2024, 10:21 PM

Jdlrobson assigned this task to GMikesell-WMF.

Jdlrobson triaged this task as Low priority.

Jdlrobson added a project: Web-Team-Backlog (FY2023-24 Q4 Sprint 6).

Jdlrobson set the point value for this task to 0.

Jdlrobson moved this task from Needs analysis to QA on the Web-Team-Backlog (FY2023-24 Q4 Sprint 6) board.

KStoller-WMF moved this task from Inbox to Triaged on the Growth-Team board.Jun 24 2024, 3:11 AM

Jdlrobson edited projects, added Web-Team-Backlog (FY2024-25 Q1 Sprint 1); removed Web-Team-Backlog (FY2023-24 Q4 Sprint 6).Mon, Jul 1, 5:35 PM

Jdlrobson moved this task from Needs analysis to QA on the Web-Team-Backlog (FY2024-25 Q1 Sprint 1) board.

Jdlrobson moved this task from Excluded experiences to Dark mode on the FY2023-24-WE 2.1 Typography and palette customizations board.Mon, Jul 1, 11:29 PM

KSarabia-WMF claimed this task.Tue, Jul 2, 10:54 PM

KSarabia-WMF added a subscriber: GMikesell-WMF.

Test Result - Prod
Status: ✅ PASS
Environment: Beta
OS: macOS Sonoma 14.5
Browser: Chrome 126
Device: MBA
Emulated Device: NA

Test Artifact(s):

Test Steps
Visit a user page in dark mode e.g. https://en.wikipedia.beta.wmflabs.org/wiki/User:Edtadros-beta1
Click the <3 symbol
White text on white background is no longer happening

KSarabia-WMF reassigned this task from KSarabia-WMF to ovasileva.Wed, Jul 3, 3:57 PM

KSarabia-WMF moved this task from QA to Ready for Signoff on the Web-Team-Backlog (FY2024-25 Q1 Sprint 1) board.

KSarabia-WMF subscribed.

GMikesell-WMF mentioned this in T367779: Verify 1.43.0-wmf.11 deployment.Wed, Jul 3, 9:37 PM

Screenshot 2024-07-08 at 13.38.17.png (1×2 px, 373 KB)

Test Result - PROD

Status: ✅ PASS
Environment: PROD
OS: macOS Sonoma 14.5
Browser: Chrome 126
Device: MBA
Emulated Device: NA

Test Artifact(s):

Test Steps

Visit a user page in dark mode e.g. https://en.wikipedia.org/wiki/User:Gmikesell-WMF
Click the <3 symbol

2024-07-15_13-48-09.png (922×1 px, 223 KB)

GMikesell-WMF added a project: Verified.Mon, Jul 15, 9:20 PM

GMikesell-WMF updated the task description. (Show Details)

	F56287224: Screenshot 2024-07-08 at 13.38.17.png
	Mon, Jul 8, 10:38 AM

	F55330466: screenshot 70.png
	Jun 17 2024, 10:04 PM
	File Not Attached

[QA only] Wikilove is not dark mode friendlyClosed, ResolvedPublic0 Estimated Story PointsBUG REPORTActions