TimedMediaHandler does not support PostgreSQL
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	0xAFFF
	Feb 7 2017, 8:54 AM

Description

I tried to install TimeMediaHandler on our internal wiki, but it failed for several reasons:

TimedMediaHandler.sql is MySQL only. No Problem, I rewrote it to conform to PostgreSQL:

CREATE TABLE /*_*/transcode (
	transcode_id SERIAL NOT NULL,
	transcode_image_name VARCHAR(255) NOT NULL,
	transcode_key VARCHAR(48) NOT NULL,
	transcode_error longtext NOT NULL,
	transcode_time_addjob VARCHAR(14) NULL,
	transcode_time_startwork VARCHAR(14) NULL,
	transcode_time_success VARCHAR(14) NULL,
	transcode_time_error VARCHAR(14) NULL,
	transcode_final_bitrate INT NOT NULL
) /*$wgDBTableOptions*/;

CREATE INDEX /*i*/transcode_time_inx ON /*_*/transcode( transcode_time_addjob ,transcode_time_startwork , transcode_time_success, transcode_time_error );
CREATE INDEX /*i*/transcode_key_idx ON /*_*/transcode( transcode_key );

CREATE UNIQUE INDEX /*i*/transcode_name_key ON /*_*/transcode (transcode_image_name,transcode_key);

Now if I try to upload a file I get this exception:

[02a6c44e6268ccd9ea6e7af1] /index.php/Spezial:Hochladen Error from line 1091 of /var/www/html/includes/specials/SpecialUpload.php: Call to a member function getUrl() on boolean

Backtrace:

#0 /var/www/html/includes/specials/SpecialUpload.php(893): UploadForm->getDescriptionSection()
#1 /var/www/html/includes/specials/SpecialUpload.php(267): UploadForm->__construct(array, DerivativeContext, MediaWiki\Linker\LinkRenderer)
#2 /var/www/html/includes/specials/SpecialUpload.php(446): SpecialUpload->getUploadForm(string, string, boolean)
#3 /var/www/html/includes/specials/SpecialUpload.php(519): SpecialUpload->showUploadWarning(array)
#4 /var/www/html/includes/specials/SpecialUpload.php(209): SpecialUpload->processUpload()
#5 /var/www/html/includes/specialpage/SpecialPage.php(522): SpecialUpload->execute(NULL)
#6 /var/www/html/includes/specialpage/SpecialPageFactory.php(576): SpecialPage->run(NULL)
#7 /var/www/html/includes/MediaWiki.php(283): SpecialPageFactory::executePath(Title, RequestContext)
#8 /var/www/html/includes/MediaWiki.php(851): MediaWiki->performRequest()
#9 /var/www/html/includes/MediaWiki.php(512): MediaWiki->main()
#10 /var/www/html/index.php(43): MediaWiki->run()
#11 {main}

The used software versions:

Softare	Version
MediaWiki	1.28.0
PHP	7.0.13 (apache2handler)
PostgreSQL	9.6.1
TimedMediaHandler	0.5.0 (64461e9) 21:18, 25. Okt. 2016
MwEmbedSupport	0.3.0 (2e24ff4) 00:03, 25. Okt. 2016

Details

	Subject	Repo	Branch	Lines +/-
	Add support for postgres to TMH	mediawiki/extensions/TimedMediaHandler	master	+17 -1

Customize query in gerrit

Related Objects

Mentioned In: T298656: Standardise type for transcode_time_* columns
T160910: File moves throw error when using postgres
Mentioned Here: T155771: Upload fails if preview cannot be generated
rEMES2e24ff47a3bf: Whoops, track not trace
rETMH64461e9ec3d4: Localisation updates from https://translatewiki.net.

Event Timeline

0xAFFF created this task.Feb 7 2017, 8:54 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 7 2017, 8:54 AM

Your problem with the uploads is T155771: Upload fails if preview cannot be generated, caused by the previews to fail.

The file move seems like a core problem, and not TMH specific (could you test that ?)

if you want, I can add that postgres to the extension. How would you like to be credited for that (name/email) ?

Paladox subscribed.Mar 20 2017, 1:01 PM

TheDJ mentioned this in T160910: File moves throw error when using postgres.Mar 20 2017, 1:19 PM

TheDJ updated the task description. (Show Details)

Change 343833 had a related patch set uploaded (by TheDJ):
[mediawiki/extensions/TimedMediaHandler] Add support for postgres to TMH

https://gerrit.wikimedia.org/r/343833

gerritbot added a project: Patch-For-Review.Mar 21 2017, 9:37 AM

Added the patch set, can update credit on the patch upon request.

Change 343833 abandoned by TheDJ:
Add support for postgres to TMH

Reason:
Original contributor is not responding. abandoning for now.

https://gerrit.wikimedia.org/r/343833

This still requires more refinement, per brion's comment in the review. Stalling this until we have a postgres user on hand.

saper subscribed.Jun 2 2017, 1:38 AM

PostgreSQL user here, anything I could help with here? I have TMH installed and with the table/indexes added File pages seem to work so far.

@IijimaYun "ISTR the pgsql schema for MediaWiki wants to use a different timestamp format... core tables use TIMESTAMPTZ instead of VARCHAR(14)"

So it seems that the last status was that the type was incorrect. Working perhaps, but not correct. If anyone can rework the patch to take that into account, then that will be appreciated.

Apologies for the delay, I somehow missed the e-mail notification completely. The 14-character fields are definitely not working as the format of the timestamps being inserted is full YYYY-MM-DD HH:MM:SS+TZ; TIMESTAMPTZ seems to work fine.

Maintenance_bot removed a project: Patch-For-Review.Aug 10 2019, 11:10 PM

Aklapper changed the task status from Stalled to Open.Jun 9 2020, 11:38 AM

Another PostgreSQL user here. I am keen to get TimedMediaHandler working with PostgreSQL. Is there anything I can do to help?

(I have not contributed to MediaWiki before, otherwise I would have contributed a patch already.)

For a quick fix with a local installation, simply ALTER the schema for transcode and use TIMESTAMPTZ.

transcode_time_addjob timestamp with time zone,
transcode_time_startwork timestamp with time zone,
transcode_time_success timestamp with time zone,
transcode_time_error timestamp with time zone,

Umherirrender mentioned this in T298656: Standardise type for transcode_time_* columns.Jan 5 2022, 8:42 PM

In T157424#7073455, @IijimaYun wrote:
For a quick fix with a local installation, simply ALTER the schema for transcode and use TIMESTAMPTZ.
transcode_time_addjob timestamp with time zone,
transcode_time_startwork timestamp with time zone,
transcode_time_success timestamp with time zone,
transcode_time_error timestamp with time zone,

There is now a db patch merged to the extension. If possible, please test with the current master or apply it manually: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/TimedMediaHandler/+/751797/2/sql/postgres/patch-transcode-transcode_timestamp.sql

If postgres now works without errors, this task could get resolved.

TheDJ moved this task from To sort to Backlog/maint on the TimedMediaHandler board.Jan 13 2022, 12:53 PM

In T157424#7603195, @Umherirrender wrote:

If postgres now works without errors, this task could get resolved.

Does anyone affected by this know? Thanks in advance.

I am planning an upgrade to 1.37.x (still on 1.36.x at the moment) within a few days and this will be a good way to test these changes; will report here on the outcome.

This problem is mentioned on https://www.mediawiki.org/wiki/Extension:TimedMediaHandler If confirmed fixed, we also need to update that page.

@IijimaYun: Any news to share?

@Aklapper, my apologies, I completely forgot to comment on this. The updated extension requires 1.38 and does not work with 1.37.1.

Setting stalled status as we need someone to test with 1.38

Umherirrender unsubscribed.Aug 31 2022, 8:01 PM

Im closing this as assumed fixed. Waiting 2+ years for testers seems long enough to me. Postgres users can open new tickets if they experience problems.

TimedMediaHandler does not support PostgreSQLClosed, ResolvedPublicActions

Description

Details

Related Objects

Event Timeline

TimedMediaHandler does not support PostgreSQL
Closed, ResolvedPublic
Actions