Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8.2 Deprecation: Fix creation of dynamic property. #55

Merged
merged 1 commit into from
Jan 8, 2024

Conversation

Soean
Copy link
Contributor

@Soean Soean commented Jan 8, 2024

If I use the super-admin command wp super-admin list with WP CLI 2.9.0 and PHP 8.2.14, I get the warning:

PHP Deprecated: Creation of dynamic property Super_Admin_Command::$fetcher is deprecated in /vendor/wp-cli/super-admin-command/src/Super_Admin_Command.php on line 32

This PR fixes the warning.

@Soean Soean requested a review from a team as a code owner January 8, 2024 11:55
@swissspidy swissspidy merged commit 9d91c13 into wp-cli:main Jan 8, 2024
2 checks passed
@swissspidy swissspidy added this to the 2.0.13 milestone Jan 8, 2024
@swissspidy swissspidy added the bug label Jan 8, 2024
@Soean Soean deleted the php-warning-fix branch January 8, 2024 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2 participants