Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix type hinting for prompt function #141

Merged
merged 2 commits into from
Nov 3, 2023
Merged

Fix type hinting for prompt function #141

merged 2 commits into from
Nov 3, 2023

Conversation

valeriySeregin
Copy link
Contributor

I was confused by phpstan analyse output: "Parameter #2 $default of function cli\prompt expects string, false given." Soon I found out that problem is in type hinting for this function in lib/cli/cli.php. Hope my fix is helpful.
swissspidy
swissspidy reviewed Nov 2, 2023
View reviewed changes
lib/cli/cli.php Outdated Show resolved Hide resolved
@swissspidy swissspidy merged commit 79e1610 into wp-cli:master Nov 3, 2023
41 checks passed
@swissspidy swissspidy added this to the 0.11.22 milestone Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement scope:documentation
2 participants
@valeriySeregin @swissspidy