-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Evaluate $upgrading
numeric value when checking if maintenance mode is active
#22
Conversation
…hecking if the site is in maintenance mode or not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd suggest we proceed forward on this path: #22 (comment)
We'll want to make sure we have a few different scenarios covering each of the potential .maintenance
file formats.
Hey guys, Thanks for the feedback; I thought to give it another try by adding the warning when the value is a non-numeric one. Also, I've changed the regex to account for when space might be missing between the |
@selul It's looking great! Just a few small things to fix up, and then this should be good to land. You'll want to make sure all of the tests are passing too. |
Co-authored-by: Daniel Bachhuber <daniel@bachhuber.co>
Co-authored-by: Daniel Bachhuber <daniel@bachhuber.co>
Co-authored-by: Daniel Bachhuber <daniel@bachhuber.co>
Thanks for the feedback @danielbachhuber 🚀 ! I've applied the changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty solid! Just two small tweaks remaining on my end. I'd love to get another @wp-cli/committers review, though.
Co-authored-by: Daniel Bachhuber <daniel@bachhuber.co>
Thanks for the feedback, @danielbachhuber! I've made the changes! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your work on this, @selul !
Attempt to fix #19 by checking the upgrading value when seeing if the site is in maintenance mode or not. Re-use the logic that core uses -> https://github.com/WordPress/WordPress/blob/master/wp-includes/load.php#L310-L314