Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly delete JSON & PHP translation files #137

Merged
merged 6 commits into from
Feb 1, 2024
Merged

Conversation

swissspidy
Copy link
Member

@swissspidy swissspidy commented Jan 31, 2024

JSON translation files were introduced in WordPress 5.0. Testing their removal is trickier as the file names contain MD5 hashes that can change, so I didn't include this.

.l10n.php are a new introduction in WordPress 6.5. Language packs served by wp.org will soon start to include those. files.

Fixes #129

@swissspidy swissspidy requested a review from a team as a code owner January 31, 2024 13:58
@swissspidy swissspidy added this to the 2.0.19 milestone Jan 31, 2024
Copy link
Member

@danielbachhuber danielbachhuber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me at a high-level. I'll defer to you on the specifics of the implementation.

@swissspidy swissspidy merged commit 4d0a2e5 into main Feb 1, 2024
36 checks passed
@swissspidy swissspidy deleted the fix/129-uninstall branch February 1, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants