Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add file references for plugin/theme headers #377

Merged
merged 2 commits into from
Jan 16, 2024
Merged

Add file references for plugin/theme headers #377

merged 2 commits into from
Jan 16, 2024

Conversation

swissspidy
Copy link
Member

Fixes #376
@swissspidy swissspidy added this to the 2.5.1 milestone Dec 18, 2023
@swissspidy swissspidy requested a review from a team as a code owner December 18, 2023 08:40
@swissspidy
Copy link
Member Author

FYI @ocean90 — would like to know if you think this makes sense or not.
@swissspidy swissspidy mentioned this pull request Dec 18, 2023
Closed
ocean90
ocean90 approved these changes Dec 18, 2023
View reviewed changes
Copy link
Contributor

@ocean90 ocean90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Would be nice to have the line numbers as well but not a blocker for me.
@swissspidy
Copy link
Member Author

swissspidy commented Dec 18, 2023 •
edited
Loading

Yeah I thought about that as well. Always thought that requires a more complex solution (see #65) but maybe using PREG_OFFSET_CAPTURE would suffice (see this SO post). I'll see how feasible it is and otherwise will file a follow-up issue.

Edit: simply reopened and repurposed #65
@swissspidy swissspidy mentioned this pull request Jan 16, 2024
Open
@swissspidy
Copy link
Member Author

@wp-cli/committers would appreciate a quick review here so I can merge this
@swissspidy swissspidy merged commit b8548b9 into main Jan 16, 2024
65 checks passed
@swissspidy swissspidy deleted the fix/376-main-file-reference branch January 16, 2024 15:59
@jkrrv jkrrv mentioned this pull request Feb 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants
@swissspidy @danielbachhuber @ocean90