make-mo: Add destination file support
#373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdnunca
force-pushed
the
feature/i18n-command-add-destination-file-support
branch
from
dc14056
to
fdf5181
Compare
swissspidy
reviewed
Nov 16, 2023
sdnunca
force-pushed
the
feature/i18n-command-add-destination-file-support
branch
3 times, most recently
from
d004b09
to
0943437
Compare
sdnunca
force-pushed
the
feature/i18n-command-add-destination-file-support
branch
from
0943437
to
c5a4442
Compare
|
Looks good to me! I'll let @swissspidy give it a final review. |
swissspidy
approved these changes
Nov 16, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the discussion in #372, the
MakeMocommand should support a destination file name.This PR allows you to specify a destination file name when the source is a file. When the source is a directory, providing a destination file name is not supported:
wp i18n make-mo foo.po-> unchanged behavior, writes foo.mo to same directory as foo.powp i18n make-mo foo.po bar.mo-> writes file to bar.mowp i18n make-mo foo/bar-> unchanged behavior, generates MO files for all PO files in the directorywp i18n make-mo foo/bar baz.mo-> won't work!