Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multisite search-replace example #451

Merged
merged 2 commits into from
Jul 21, 2023

Conversation

kevinfodness
Copy link
Contributor

Adds the --network flag and the wp_site table to the example about how to prepare a multisite for local development:

  • Without the --network flag, the wildcard in the example for performing a search-replace across all options tables for all subsites fails to match subsite options tables and only matches the main options table (e.g., wp_options).
  • Without the wp_site table, the search-replace for domains is incomplete if targeting the primary site.
@kevinfodness kevinfodness requested a review from a team as a code owner June 8, 2023 23:39
Copy link
Member

@danielbachhuber danielbachhuber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pull request, @kevinfodness !

This documentation is actually generated from the codebase on every release. As such, your change will be blown away on the next release unless it's applied to the codebase too.

Can you submit a PR to apply your change to https://github.com/wp-cli/search-replace-command/blob/main/src/Search_Replace_Command.php#L158-L159 too?

Copy link
Member

@danielbachhuber danielbachhuber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went ahead and ported this over: wp-cli/search-replace-command#187

@danielbachhuber danielbachhuber merged commit 6a6df20 into wp-cli:main Jul 21, 2023
@kevinfodness
Copy link
Contributor Author

Thank you! This was on my to-do list but I hadn't gotten to it yet.

@kevinfodness kevinfodness deleted the fix/search-replace-docs branch July 24, 2023 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants