Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve SQLite compatibility #243

Merged
merged 9 commits into from
Nov 4, 2023
Merged

Improve SQLite compatibility #243

merged 9 commits into from
Nov 4, 2023

Conversation

swissspidy
Copy link
Member

Fixes #242

@swissspidy swissspidy marked this pull request as ready for review October 23, 2023 17:25
@swissspidy swissspidy requested a review from a team as a code owner October 23, 2023 17:25
Copy link
Member

@danielbachhuber danielbachhuber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make sure there are GitHub issues open for the TODO comments? They will probably be forgotten otherwise.

Also, I'm a little bit wary of all of the @require-mysql statements because it means we're skipping the tests for SQLite. I don't think it necessarily blocks this, but we might want to track it in some way.

@danielbachhuber
Copy link
Member

Also, I'm a little bit wary of all of the @require-mysql statements because it means we're skipping the tests for SQLite. I don't think it necessarily blocks this, but we might want to track it in some way.

Another potential way to solve this: create a custom Matrix for the SQLite tests, and only run SQLite for WordPress 6.0 and higher. I think this would be my recommended approach.

@swissspidy
Copy link
Member Author

Another potential way to solve this: create a custom Matrix for the SQLite tests, and only run SQLite for WordPress 6.0 and higher.

This is already the case, actually. What's happening here is that some individual scenarios downgrade to WordPress 4.0 and then upgrade to the latest version.

Can we make sure there are GitHub issues open for the TODO comments? They will probably be forgotten otherwise.

Totally. The only TODO that doesn't have one yet is the one about CUSTOM_USER_TABLE. I'm not yet sure whether it's an issue with the command or the SQLite plugin.

@swissspidy swissspidy added this to the 2.1.16 milestone Oct 26, 2023
@swissspidy
Copy link
Member Author

@danielbachhuber WDYT about the reworded comments?

features/core-install.feature Outdated Show resolved Hide resolved
features/core-install.feature Show resolved Hide resolved
features/core-install.feature Show resolved Hide resolved
features/core-check-update.feature Outdated Show resolved Hide resolved
features/core-update-db.feature Outdated Show resolved Hide resolved
@danielbachhuber danielbachhuber merged commit 91b4e0c into main Nov 4, 2023
41 checks passed
@danielbachhuber danielbachhuber deleted the fix/242-sqlite branch November 4, 2023 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants