Add pluck/patch commands for caches and transients #89

petitphp · 2023-07-25T14:50:31Z

Add commands for plucking and patching values from object cache and transient.

Fixes #26

petitphp · 2023-08-28T14:14:51Z

I cannot reproduce the failures for the functional tests locally :

$ composer behat                                                                 
> run-behat-tests
...................................................................... 70
...................................................................... 140
...................................................................... 210
...................................................................... 280
...................................................................... 350
................

20 scénarios (20 succès)
366 étapes (366 succès)
4m20.27s (10.47Mb)

Seem's like the mu-plugins used to set up those scenarios are not loaded.

danielbachhuber

I cannot reproduce the failures for the functional tests locally :

Yeah, the tests pass locally for me too.

I don't know what the issue might be. @wp-cli/committers Any ideas?

features/cache.feature

features/transient.feature

features/cache.feature

swissspidy · 2023-08-30T10:02:25Z

Unfortunately can't reproduce locally either.

Looks like $current_value is null, so the wp_cache_get() call in the patch() method is returning null for some reason..?

Adding some WP_CLI::log( var_export( wp_cache_get( 'my_key' ), true ) ); calls to within $set_foo could help debug this.

petitphp · 2023-09-07T07:53:14Z

I manage to reproduce the failling tests locally after rebasing main in the branch, I'll look into it.

Scratch that, it was an issue with the rebase 🥲

petitphp · 2023-09-07T08:11:32Z

@danielbachhuber I've split the tests into dedicated files and update them to use When I run if they're expected to succeed.

In 327d99a I added two debug statement to try to understand why the tests are failing in Github CI.

petitphp · 2023-09-18T19:50:29Z

@danielbachhuber I was finally able to fix the failures for the functional tests. It was related to the use of STDIN to get the new value, which didn't properly handle the case where it was empty.

All tests are green on my fork.

danielbachhuber

Nice work getting the tests working, @petitphp !

I left a few comments to work through.

src/Cache_Command.php

src/Cache/RecursiveDataStructureTraverser.php

src/Cache_Command.php

danielbachhuber · 2023-09-18T21:08:04Z

features/transient-patch.feature

+        set_transient( 'my_key_2', ['foo' => ['bar' => 'baz']] );
+      };
+
+      WP_CLI::add_hook( 'before_invoke:transient patch', $set_foo );


Can we use wp transient set to set these initial transient values? The transient cache is persistent in vanilla WordPress, so we shouldn't need to hook into the command invocation in this manner.

Originally I was planing on using wp transient set but it is not possible to set array-like data directly like what's possible with wp option add/update (maybe an idea for a future PR to add this).

I've found another solution by using the wp eval command to execute a set_transient

Given a WP install And I run `wp eval "set_transient( 'my_key', ['foo' => 'bar'] );"` And I run `wp eval "set_transient( 'my_key_2', ['foo' => ['bar' => 'baz']] );"`

features/transient-patch.feature

danielbachhuber · 2023-09-18T21:10:26Z

src/Transient_Command.php

+		$traverser = new RecursiveDataStructureTraverser( $current_value );
+
+		try {
+			$traverser->$action( $key_path, $patch_value );


How does the actual transient value get saved?

The transient value is updated later in the elseif condition by using the function store in the $write_func variable.

johnbillion · 2023-11-10T14:41:12Z

What's left to do on this PR?

petitphp · 2023-11-15T08:21:11Z

Hi @johnbillion, sorry for the delay.

I didn't had the time to look at Daniel comments yet. I'll try to check them this week and finish up this PR for a new review.

petitphp · 2023-12-12T08:32:00Z

Hi @danielbachhuber,

I've refactored the feature tests to address your feedbacks, this should be good to go.

All tests workflows using MySQL are green, the ones with SQLite are failing, but doesn't seem related to this PR specifically (eg: Functional - WP latest on 8.2 with SQLite).

swissspidy · 2024-01-08T12:24:15Z

SQLite errors are known, see #92

petitphp · 2024-04-19T18:01:57Z

Hi, this PR should be ready for final review, the failling tests are related to SQLite errors and not to the changes in this PR.

Split features for patch/pluck commands into their own file and use `When I run` for commands when they have a successful outcome.

Co-authored-by: Daniel Bachhuber <daniel@bachhuber.co>

…t get`

…ecks

src/Cache_Command.php

src/Transient_Command.php

Co-authored-by: Pascal Birchler <pascal.birchler@gmail.com>

petitphp force-pushed the feature/pluck-patch-cache-transient branch from 8787b05 to f31a3dd Compare July 31, 2023 19:49

petitphp marked this pull request as ready for review August 23, 2023 22:18

petitphp requested a review from a team as a code owner August 23, 2023 22:18

danielbachhuber requested changes Aug 29, 2023

View reviewed changes

petitphp force-pushed the feature/pluck-patch-cache-transient branch from 4f765d0 to 6e5ecdf Compare September 7, 2023 08:06

petitphp force-pushed the feature/pluck-patch-cache-transient branch 10 times, most recently from 6cd56d8 to e75e7c1 Compare September 18, 2023 14:11

danielbachhuber mentioned this pull request Sep 18, 2023

Resolve duplicate copies of RecursiveDataStructureTraverser wp-cli/wp-cli#5837

Closed

danielbachhuber requested changes Sep 18, 2023

View reviewed changes

petitphp requested a review from danielbachhuber December 12, 2023 08:32

danielbachhuber mentioned this pull request Jan 30, 2024

Release checklist for v2.10.0 wp-cli/wp-cli#5891

Closed

36 tasks

petitphp force-pushed the feature/pluck-patch-cache-transient branch from b9d6f5e to d8ef33a Compare April 26, 2024 08:36

petitphp and others added 22 commits April 26, 2024 17:05

add pluck command to cache

4974e33

add pluck command to transient

d3c91c2

add patch command to cache

4124069

add patch command to transient

331de25

Add missing expiration option for patch cache command

6a85183

Fix cs

b59a81e

Update Behat features tests

fb6d809

Split features for patch/pluck commands into their own file and use `When I run` for commands when they have a successful outcome.

Add temporary log to debug failing tests in github action

ae829e8

Small CS fixes for WPCS v3

ff67d79

Fix failing functional tests

9f6ffe8

Add tests for RecursiveDataStructureTraverser.php

507dd4e

Fix wrong command in docblock

8edecf6

Co-authored-by: Daniel Bachhuber <daniel@bachhuber.co>

Fix CS issue

a562da3

Co-authored-by: Daniel Bachhuber <daniel@bachhuber.co>

Reuse has_stdin() from framework

8625084

Fix PHPCS issues

b440613

Use wp eval to set the transient

7653b8c

split patch feature tests and add additionnal checks with `transien…

5018960

…t get`

split patch feature tests for site transient and add additionnal ch…

0e80f6f

…ecks

Add test cases for invalid keys

38a8911

Refactor pluck feature tests to use wp eval to set the transient

fb1fd05

new feature test for calling cache pluck command with invalid key

303e129

add the new commands to the composer.json

a2018a5

petitphp force-pushed the feature/pluck-patch-cache-transient branch from c0e3c62 to a2018a5 Compare April 26, 2024 15:05

swissspidy reviewed Apr 26, 2024

View reviewed changes

src/Cache_Command.php Outdated Show resolved Hide resolved

swissspidy reviewed Apr 26, 2024

View reviewed changes

src/Transient_Command.php Outdated Show resolved Hide resolved

petitphp and others added 3 commits April 29, 2024 14:36

use string interpolation for building message

f1905af

Co-authored-by: Pascal Birchler <pascal.birchler@gmail.com>

explicitly call update methods for clearer code

eac9da1

Co-authored-by: Pascal Birchler <pascal.birchler@gmail.com>

fix tests

44903e8

swissspidy modified the milestones: 2.1.3, 2.2.0 May 4, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add pluck/patch commands for caches and transients #89

Add pluck/patch commands for caches and transients #89

petitphp commented Jul 25, 2023 •

edited by danielbachhuber

Loading

petitphp commented Aug 28, 2023 •

edited

Loading

danielbachhuber left a comment

swissspidy commented Aug 30, 2023

petitphp commented Sep 7, 2023 •

edited

Loading

petitphp commented Sep 7, 2023

petitphp commented Sep 18, 2023

danielbachhuber left a comment

danielbachhuber Sep 18, 2023

petitphp Dec 1, 2023 •

edited

Loading

danielbachhuber Sep 18, 2023

petitphp Dec 1, 2023

johnbillion commented Nov 10, 2023

petitphp commented Nov 15, 2023

petitphp commented Dec 12, 2023

swissspidy commented Jan 8, 2024

petitphp commented Apr 19, 2024

Add pluck/patch commands for caches and transients #89

Are you sure you want to change the base?

Add pluck/patch commands for caches and transients #89

Conversation

petitphp commented Jul 25, 2023 • edited by danielbachhuber Loading

petitphp commented Aug 28, 2023 • edited Loading

danielbachhuber left a comment

Choose a reason for hiding this comment

swissspidy commented Aug 30, 2023

petitphp commented Sep 7, 2023 • edited Loading

petitphp commented Sep 7, 2023

petitphp commented Sep 18, 2023

danielbachhuber left a comment

Choose a reason for hiding this comment

danielbachhuber Sep 18, 2023

Choose a reason for hiding this comment

petitphp Dec 1, 2023 • edited Loading

Choose a reason for hiding this comment

danielbachhuber Sep 18, 2023

Choose a reason for hiding this comment

petitphp Dec 1, 2023

Choose a reason for hiding this comment

johnbillion commented Nov 10, 2023

petitphp commented Nov 15, 2023

petitphp commented Dec 12, 2023

swissspidy commented Jan 8, 2024

petitphp commented Apr 19, 2024

petitphp commented Jul 25, 2023 •

edited by danielbachhuber

Loading

petitphp commented Aug 28, 2023 •

edited

Loading

petitphp commented Sep 7, 2023 •

edited

Loading

petitphp Dec 1, 2023 •

edited

Loading