Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We��ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update warning text during multisite cache flushes #88

Merged
merged 1 commit into from
Jul 25, 2023
Merged

Update warning text during multisite cache flushes #88

merged 1 commit into from
Jul 25, 2023

Conversation

WPprodigy
Copy link
Contributor

@WPprodigy WPprodigy commented Jul 24, 2023 •
edited by swissspidy
Loading

Update to the text from #86, fixes #78.

Context: Some object cache implementations won't flush the entire network, and the --url= param is still useful. Since WP CLI is still switching context to the site in question, we shouldn't use the "ignoring" verbiage as that isn't truly accurate.
@WPprodigy WPprodigy requested a review from a team as a code owner July 24, 2023 23:21
danielbachhuber
danielbachhuber approved these changes Jul 25, 2023
View reviewed changes
Copy link
Member

@danielbachhuber danielbachhuber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!
@danielbachhuber danielbachhuber added this to the 2.1.1 milestone Jul 25, 2023
@danielbachhuber danielbachhuber merged commit b4726ce into wp-cli:main Jul 25, 2023
31 checks passed
@WPprodigy WPprodigy deleted the fix/78-update-cache-flush-warning branch August 15, 2023 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
command:cache command:cache-flush
2 participants
@WPprodigy @danielbachhuber