Make VerifiedDX11 Great Again #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Somewhere along the way as part of the vs2022 changes, VerifiedDX11 picked up a bunch of options it wasn't previously using. Notable changes: * StringPooling: Set back to default for some projects. * FunctionLevelLinking: Set back to default for some projects. * BufferSecurityCheck: Enable. * ForceConformanceInForLoopScope: Enable. * MinimalRebuild: Disable. This destroys build time performance by an order of magnitude as it disables the compiler's use of multiprocessing (/MP). Plus it's deprecated. * RuntimeTypeInfo: Enable (as it was previously enabled). * xrEngine: Fix broken library paths which were referring to the 'Release' config. This is what caused the libogg_static.lib error. * ReShadeCompat: Make consistent with the other 3rd party projects. * VerifiedDX11 is basically the equivalent of DX11 but with additional debugging and security options enabled. As such it should follow the paradigm of xrEngine using the 'VerifiedDX11' config but everything else using a generic 'Verified' config. * xrCore: xrMemory.h: Use typeinfo rather than typeinfo.h. This was missed as part of the vs2022 cleanups but only was apparent with DEBUG enabled. * xrGame: Inventory.cpp: Do not rely on /Zc:forScope-. Noticed while reenabling ForceConformanceInForLoopScope. * xrEngine: x_ray.cpp: Remove stray character.
themrdemonized
added a commit
that referenced
this pull request
Aug 12, 2023
…-again Make VerifiedDX11 Great Again (cherry picked from commit 834e988)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Somewhere along the way as part of the vs2022 changes, VerifiedDX11 picked up a bunch of options it wasn't previously using. Notable changes:
StringPooling: Set back to default for some projects.
FunctionLevelLinking: Set back to default for some projects.
BufferSecurityCheck: Enable.
ForceConformanceInForLoopScope: Enable.
MinimalRebuild: Disable. This destroys build time performance by an order of magnitude as it disables the compiler's use of multiprocessing (/MP). Plus it's deprecated.
RuntimeTypeInfo: Enable (as it was previously enabled).
xrEngine: Fix broken library paths which were referring to the 'Release' config. This is what caused the libogg_static.lib error.
ReShadeCompat: Make consistent with the other 3rd party projects.
VerifiedDX11 is basically the equivalent of DX11 but with additional debugging and security options enabled. As such it should follow the paradigm of xrEngine using the 'VerifiedDX11' config but everything else using a generic 'Verified' config.
xrCore: xrMemory.h: Use typeinfo rather than typeinfo.h. This was missed as part of the vs2022 cleanups but only was apparent with DEBUG enabled.
xrGame: Inventory.cpp: Do not rely on /Zc:forScope-. Noticed while reenabling ForceConformanceInForLoopScope.
xrEngine: x_ray.cpp: Remove stray character.