xrTrims.cpp: Fix _CopyVal to actually be safe #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
clayne
commented
Aug 12, 2023
clayne
commented
- _CopyVal: Called by _GetItem (which explicitly takes a dst_size argument), this function will stomp dst if the tokenized string is longer than the size of dst. Fix this by actually using a dst_size argument (which the caller already has) and clamping the strncpy to it.
* _CopyVal: Called by _GetItem (which explicitly takes a dst_size argument), this function will stomp dst if the tokenized string is longer than the size of dst. Fix this by actually using a dst_size argument (which the caller already has) and clamping the strncpy to it.
themrdemonized
added a commit
that referenced
this pull request
Aug 12, 2023
xrTrims.cpp: Fix _CopyVal to actually be safe (cherry picked from commit c5a4d49)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.