New package: Nvidia.ProfileInspector version 2.4.0.4 #162241
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
wingetbot
added
the
Internal-Error-Dynamic-Scan
microsoft-github-policy-service
bot
added
the
Needs-Attention
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
microsoft-github-policy-service
bot
removed
Internal-Error-Dynamic-Scan
wingetbot
added
the
Internal-Error-Dynamic-Scan
microsoft-github-policy-service
bot
added
the
Needs-Attention
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
microsoft-github-policy-service
bot
removed
Internal-Error-Dynamic-Scan
wingetbot
added
the
Internal-Error-Dynamic-Scan
microsoft-github-policy-service
bot
added
the
Needs-Attention
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
microsoft-github-policy-service
bot
removed
Internal-Error-Dynamic-Scan
wingetbot
added
the
Internal-Error-Dynamic-Scan
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
microsoft-github-policy-service
bot
removed
Internal-Error-Dynamic-Scan
wingetbot
added
the
Internal-Error-Dynamic-Scan
microsoft-github-policy-service
bot
added
the
Needs-Attention
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
microsoft-github-policy-service
bot
removed
Internal-Error-Dynamic-Scan
wingetbot
added
New-Package
Azure-Pipeline-Passed
|
Hi @devCKVargas, This package installed normally, but gave this error when launched: Many of nVidia's applications require their hardware to operate, but the error message is usually much more clear. It seems more like a missing dependency or an installer error. What do you think? |
stephengillie
added
the
Needs-Author-Feedback
Trenly
suggested changes
Jul 14, 2024
| # Created with komac v2.3.0 | ||
| # yaml-language-server: $schema=https://aka.ms/winget-manifest.installer.1.6.0.schema.json | ||
|
|
||
| PackageIdentifier: Nvidia.ProfileInspector |
There was a problem hiding this comment.
Suggested change
| PackageIdentifier: Nvidia.ProfileInspector | |
| PackageIdentifier: Orbmu2k.NvidiaProfileInspector |
Best practice for package identifiers is Publisher.PackageName to avoid confusion. After updating this, you will need to also update the folder and name of the manifest files
There was a problem hiding this comment.
Thanks, I'll keep that in mind and follow it up in my future PRs.
My hands are too full right now, but I'll get back to it when I'm a little freer.
| # Created with komac v2.3.0 | ||
| # yaml-language-server: $schema=https://aka.ms/winget-manifest.defaultLocale.1.6.0.schema.json | ||
|
|
||
| PackageIdentifier: Nvidia.ProfileInspector |
There was a problem hiding this comment.
Suggested change
| PackageIdentifier: Nvidia.ProfileInspector | |
| PackageIdentifier: Orbmu2k.NvidiaProfileInspector |
| # Created with komac v2.3.0 | ||
| # yaml-language-server: $schema=https://aka.ms/winget-manifest.version.1.6.0.schema.json | ||
|
|
||
| PackageIdentifier: Nvidia.ProfileInspector |
There was a problem hiding this comment.
Suggested change
| PackageIdentifier: Nvidia.ProfileInspector | |
| PackageIdentifier: Orbmu2k.NvidiaProfileInspector |
| PackageName: Nvidia Profile Inspector | ||
| License: MIT | ||
| LicenseUrl: https://github.com/Orbmu2k/nvidiaProfileInspector/blob/master/LICENSE | ||
| Copyright: Copyright (c) 2016 Orbmu2k |
There was a problem hiding this comment.
This matches the license page, but not what is shown in the application
There was a problem hiding this comment.
Hmm, not quite sure how to resolve this since the LICENSE from the repo hasn't been modified for more than 8 years now.
microsoft-github-policy-service
bot
added
the
Changes-Requested
microsoft-github-policy-service
bot
added
the
No-Recent-Activity
auto-merge was automatically disabled
July 23, 2024 08:18
Pull request was closed
microsoft-github-policy-service
bot
added
Needs-Attention
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request has been created with komac v2.3.0 🚀
Microsoft Reviewers: Open in CodeFlow