Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QTIP case only delete raw socket #4387

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

QTIP case only delete raw socket #4387

wants to merge 1 commit into from

Conversation

ami-GS
Copy link
Contributor

@ami-GS ami-GS commented Jul 5, 2024

Description

QTIP case has been failing recently.
segfault by SocketProc->RefCount become negative value, but SocketProc under normal socket is not touched at all for QTIP case.

Testing

See automation.

Documentation

N/A

@ami-GS ami-GS requested a review from a team as a code owner July 5, 2024 21:13
Copy link

codecov bot commented Jul 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.05%. Comparing base (db66ab9) to head (b72ac7f).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4387      +/-   ##
==========================================
- Coverage   85.02%   84.05%   -0.98%     
==========================================
  Files          56       56              
  Lines       15457    15457              
==========================================
- Hits        13143    12993     -150     
- Misses       2314     2464     +150     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ami-GS
Copy link
Contributor Author

ami-GS commented Jul 5, 2024

Datagram->Length become too small. only server side. looks like Path->Allowance logic relates.
IPv6 and ServerInitiatedStreams

e.g. .\artifacts\bin\windows\x64_Debug_schannel\msquictest.exe --gtest_filter="AppData/WithSendArgs1.Send/329" --duoNic --useQTIP
(27 >= 14 + 16)

CXPLAT_DBG_ASSERT(Builder->Datagram->Length >= (uint32_t)(Builder->DatagramLength + Builder->EncryptionOverhead));

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
1 participant