Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle error from RawDataPathInitialize #4385

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ami-GS
Copy link
Contributor

@ami-GS ami-GS commented Jul 3, 2024

Description

Error from RawDataPathInitialize has been ignored because it is optional.
Handle the error as the raw datapath is now user opt-in.

Testing

See automation

Documentation

N/A

@ami-GS ami-GS requested a review from a team as a code owner July 3, 2024 22:44
@ami-GS ami-GS force-pushed the dev/daiki/raw_return_error branch from 8fa413c to 5f91b09 Compare July 3, 2024 22:46
Copy link

codecov bot commented Jul 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.30%. Comparing base (394f1d1) to head (5f91b09).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4385      +/-   ##
==========================================
- Coverage   84.40%   84.30%   -0.11%     
==========================================
  Files          56       56              
  Lines       15426    15426              
==========================================
- Hits        13021    13005      -16     
- Misses       2405     2421      +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@nibanks nibanks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change seems ok, but for our test code, it explicitly needs to test the XDP datapaths. So it needs to know if this failed. What do we do for that? I think this PR should update the tests to validate XDP is used when expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants