Spinquic to use operation priority #4351
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4351 +/- ##
===========================================
- Coverage 84.14% 72.97% -11.18%
===========================================
Files 56 56
Lines 15457 15459 +2
===========================================
- Hits 13007 11281 -1726
- Misses 2450 4178 +1728 ☔ View full report in Codecov by Sentry. |
|
What! CIFuzz passes!! |
src/core/connection.h
Outdated
| @@ -1067,6 +1067,10 @@ QuicConnRelease( | |||
| QuicConnValidate(Connection); | |||
|
|
|||
| #if DEBUG | |||
| if (Connection->RefTypeCount[Ref] <= 0) { | |||
| fprintf(stderr, "RefTypeCount[%d] is %d\n", Ref, Connection->RefTypeCount[Ref]); | |||
There was a problem hiding this comment.
RefTypeCount[6] is -22829
RefTypeCount is short type (from -32,768 to 32,767). So not just off-by-one issue
There was a problem hiding this comment.
OSS-Fuzz issue dashboard has been listing same issue and the cause seems to be from other PR?
https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=68176&q=msquic
https://oss-fuzz.com/testcase-detail/4533150459756544
d65bb1a...102a491
There was a problem hiding this comment.
There was a problem hiding this comment.
My guess is that the combination of the that change and priority exposes some bug, most likely in spinquic, for object lifetime. But I have no idea specifically what could be causing it.
This reverts commit 102a491.
ami-GS
force-pushed
the
dev/daiki/spinquic_op_priority
branch
from
19a7da5
to
6bff42e
Compare
Description
Spinquic to use StreamSend, StreamStart and Get/SetParm op priorities.
Testing
See automation
Documentation
N/A