Log QUIC_TLS_SECRETS on all TestConnections and write to disk on cleanup #4349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4349 +/- ##
==========================================
- Coverage 85.36% 85.14% -0.23%
==========================================
Files 56 56
Lines 15426 15426
==========================================
- Hits 13169 13134 -35
- Misses 2257 2292 +35 ☔ View full report in Codecov by Sentry. |
ami-GS
reviewed
Jun 14, 2024
| @@ -17,6 +17,8 @@ enum NEW_STREAM_START_TYPE { | |||
| NEW_STREAM_START_ASYNC // Start asynchronously | |||
| }; | |||
|
|
|||
| #define DEFAULT_SSLKEYLOGFILE_PATH "sslkeylogfile.txt" | |||
There was a problem hiding this comment.
I don't know what word to use to describe that it's both path and filename without writing that out and making the name longer
…to disk on cleanup.
… it still crashes.
anrossi
force-pushed
the
anrossi/test-log-tls-secrets
branch
from
68f814f
to
343a1e9
Compare
|
DO NOT COMPLETE THIS PR. Trying out using a different |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Logs QUIC_TLS_SECRETs on all TestConnections. If a filepath is provided, then it will write the QUIC_TLS_SECRETS in an sslkeylogfile format to the provided file path when the TestConnection is destructed.
Testing
CI
Documentation
N/A