Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple Receive API Support #4182

Open
wants to merge 46 commits into
base: main
Choose a base branch
from
Open

Multiple Receive API Support #4182

wants to merge 46 commits into from

Conversation

nibanks
Copy link
Member

@nibanks nibanks commented Mar 8, 2024

Description

Adds a settings for apps to configure streams to support multiple parallel receives.

Testing

TODO

Documentation

TODO

@nibanks nibanks added Area: API Area: Core Related to the shared, core protocol logic labels Mar 8, 2024
src/core/settings.c Dismissed Show dismissed Hide dismissed
Copy link

codecov bot commented Apr 26, 2024

Codecov Report

Attention: Patch coverage is 96.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 85.70%. Comparing base (db66ab9) to head (79ce0b7).
Report is 2 commits behind head on main.

Files Patch % Lines
src/core/settings.c 94.11% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4182      +/-   ##
==========================================
+ Coverage   85.02%   85.70%   +0.67%     
==========================================
  Files          56       56              
  Lines       15457    15475      +18     
==========================================
+ Hits        13143    13263     +120     
+ Misses       2314     2212     -102     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ami-GS
Copy link
Contributor

ami-GS commented Jun 19, 2024

1G send sometimes hit assert here

CXPLAT_DBG_ASSERT(ChunkLength);

@ami-GS
Copy link
Contributor

ami-GS commented Jun 19, 2024

hit

CXPLAT_DBG_ASSERT((uint64_t)AllocLength + (uint64_t)Chunk->AllocLength < UINT32_MAX);

@ami-GS
Copy link
Contributor

ami-GS commented Jun 19, 2024

RecvBuffer->ReadLength seems to have synchronization issue. Especially after resizing chunk

@ami-GS
Copy link
Contributor

ami-GS commented Jun 21, 2024

This guy does bad. Not necessarily the cap split the draining range. Or simply split ranges maybe not indicated to an app.

QuicRangeSize(&RecvBuffer->WrittenRanges) > 1) {

src/core/recv_buffer.h Outdated Show resolved Hide resolved
src/core/recv_buffer.c Fixed Show fixed Hide fixed
@ami-GS ami-GS force-pushed the nibanks/multi-recv-api branch 3 times, most recently from 86a2976 to 5851412 Compare July 1, 2024 17:04
src/core/stream_recv.c Outdated Show resolved Hide resolved
src/test/lib/DataTest.cpp Outdated Show resolved Hide resolved
src/tools/spin/spinquic.cpp Outdated Show resolved Hide resolved
src/core/recv_buffer.c Outdated Show resolved Hide resolved
@ami-GS
Copy link
Contributor

ami-GS commented Jul 8, 2024

Where to handle remaining ReadPendingLength. App? api.c? stream_recv.c? recv_buff.c?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: API Area: Core Related to the shared, core protocol logic
2 participants