-
Notifications
You must be signed in to change notification settings - Fork 526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiple Receive API Support #4182
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4182 +/- ##
==========================================
+ Coverage 85.02% 85.70% +0.67%
==========================================
Files 56 56
Lines 15457 15475 +18
==========================================
+ Hits 13143 13263 +120
+ Misses 2314 2212 -102 ☔ View full report in Codecov by Sentry. |
9398cd9
to
e2500a6
Compare
e2500a6
to
a1f2339
Compare
1G send sometimes hit assert here Line 688 in a1f2339
|
hit Line 352 in a1f2339
|
RecvBuffer->ReadLength seems to have synchronization issue. Especially after resizing chunk |
This guy does bad. Not necessarily the cap split the draining range. Or simply split ranges maybe not indicated to an app. Line 926 in a1f2339
|
ed0d19b
to
1f9786c
Compare
86a2976
to
5851412
Compare
5851412
to
f5e7950
Compare
ddb7d2e
to
2fcb778
Compare
Where to handle remaining ReadPendingLength. App? api.c? stream_recv.c? recv_buff.c? |
30d6067
to
714042c
Compare
d621df0
to
8893063
Compare
Description
Adds a settings for apps to configure streams to support multiple parallel receives.
Testing
TODO
Documentation
TODO