vagrant executor support #3072
Closed
vagrant executor support #3072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sonichi
requested review from
yenif,
gbrvalerio,
AaronWard,
skzhang1,
davorrunje,
abhaymathur21,
asandez1 and
gregnwosu
|
Can you please add tests and fix the failing pre-commit check? You can get started with pre-commit here: https://pre-commit.com/#install |
thinkall
reviewed
Jul 7, 2024
There was a problem hiding this comment.
Thank you very much for the PR, @RuijingGuo ! Could you please provide an example of usage and also unit tests for the vagrant executor? Thanks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
in same case for example kernel driver, install kernel driver is risky for host.
vagrant executor can be more safe than docker executor in this case.
Related issue number
Checks