Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Qdrant support for the VectorDB interface #3035

Merged
merged 7 commits into from
Jul 15, 2024

Conversation

Anush008
Copy link
Collaborator

@Anush008 Anush008 commented Jun 28, 2024

Description

Adds a Qdrant - https://qdrant.tech/ based implementation for the VectorDB interface.

Checks

  • I've written tests to cover the implemented code.
@Anush008 Anush008 changed the title feat: Qdrant support Jun 28, 2024
@Anush008 Anush008 marked this pull request as ready for review July 1, 2024 05:47
Copy link
Collaborator

@thinkall thinkall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for the PR, @Anush008 !

Would you like to update the notebook example as well?

autogen/agentchat/contrib/vectordb/base.py Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Jul 2, 2024

Codecov Report

Attention: Patch coverage is 0% with 104 lines in your changes missing coverage. Please review.

Project coverage is 23.18%. Comparing base (6279247) to head (8e78d2f).
Report is 17 commits behind head on main.

Files Patch % Lines
autogen/agentchat/contrib/vectordb/qdrant.py 0.00% 99 Missing and 2 partials ⚠️
autogen/agentchat/contrib/vectordb/base.py 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3035      +/-   ##
==========================================
- Coverage   32.90%   23.18%   -9.72%     
==========================================
  Files          94       96       +2     
  Lines       10235    10531     +296     
  Branches     2193     2415     +222     
==========================================
- Hits         3368     2442     -926     
- Misses       6580     7830    +1250     
+ Partials      287      259      -28     
Flag Coverage Δ
unittest 12.15% <0.00%> (?)
unittests 22.41% <0.00%> (-10.49%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

gitguardian bot commented Jul 15, 2024

⚠️ GitGuardian has uncovered 8 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

Since your pull request originates from a forked repository, GitGuardian is not able to associate the secrets uncovered with secret incidents on your GitGuardian dashboard.
Skipping this check run and merging your pull request will create secret incidents on your GitGuardian dashboard.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
12853598 Triggered Generic High Entropy Secret 8e78d2f test/oai/test_utils.py View secret
10404693 Triggered Generic High Entropy Secret 8e78d2f test/oai/test_utils.py View secret
12853599 Triggered Generic High Entropy Secret 8e78d2f test/oai/test_utils.py View secret
12853600 Triggered Generic High Entropy Secret 8e78d2f test/oai/test_utils.py View secret
12853601 Triggered Generic High Entropy Secret 8e78d2f test/oai/test_utils.py View secret
10404696 Triggered Generic High Entropy Secret 8e78d2f test/oai/test_utils.py View secret
10422482 Triggered Generic High Entropy Secret 8e78d2f test/oai/test_utils.py View secret
12853602 Triggered Generic High Entropy Secret 8e78d2f test/oai/test_utils.py View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@thinkall thinkall mentioned this pull request Jul 15, 2024
11 tasks
Copy link
Collaborator

@thinkall thinkall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Anush008 , when I tried to use it in a notebook, I saw more issues: get_docs_by_ids is not working as expected as well. Could you address the issues and see it work in a notebook? Thanks.

autogen/agentchat/contrib/vectordb/qdrant.py Outdated Show resolved Hide resolved
autogen/agentchat/contrib/vectordb/qdrant.py Outdated Show resolved Hide resolved
@thinkall thinkall enabled auto-merge July 15, 2024 13:16
@thinkall thinkall added this pull request to the merge queue Jul 15, 2024
auto-merge was automatically disabled July 15, 2024 13:21

Head branch was pushed to by a user without write access

Merged via the queue into microsoft:main with commit 5b1dc3b Jul 15, 2024
132 of 150 checks passed
@Anush008 Anush008 deleted the qdrant branch July 15, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants