-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Qdrant support for the VectorDB interface #3035
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much for the PR, @Anush008 !
Would you like to update the notebook example as well?
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3035 +/- ##
==========================================
- Coverage 32.90% 23.18% -9.72%
==========================================
Files 94 96 +2
Lines 10235 10531 +296
Branches 2193 2415 +222
==========================================
- Hits 3368 2442 -926
- Misses 6580 7830 +1250
+ Partials 287 259 -28
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
---|---|---|---|---|---|
12853598 | Triggered | Generic High Entropy Secret | 8e78d2f | test/oai/test_utils.py | View secret |
10404693 | Triggered | Generic High Entropy Secret | 8e78d2f | test/oai/test_utils.py | View secret |
12853599 | Triggered | Generic High Entropy Secret | 8e78d2f | test/oai/test_utils.py | View secret |
12853600 | Triggered | Generic High Entropy Secret | 8e78d2f | test/oai/test_utils.py | View secret |
12853601 | Triggered | Generic High Entropy Secret | 8e78d2f | test/oai/test_utils.py | View secret |
10404696 | Triggered | Generic High Entropy Secret | 8e78d2f | test/oai/test_utils.py | View secret |
10422482 | Triggered | Generic High Entropy Secret | 8e78d2f | test/oai/test_utils.py | View secret |
12853602 | Triggered | Generic High Entropy Secret | 8e78d2f | test/oai/test_utils.py | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Anush008 , when I tried to use it in a notebook, I saw more issues: get_docs_by_ids
is not working as expected as well. Could you address the issues and see it work in a notebook? Thanks.
Head branch was pushed to by a user without write access
Description
Adds a Qdrant - https://qdrant.tech/ based implementation for the
VectorDB
interface.Checks