Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CAP] Convenience methods for protobuf and some minor refactoring #3022

Merged
merged 18 commits into from
Jul 23, 2024

Conversation

rajan-chari
Copy link
Collaborator

@rajan-chari rajan-chari commented Jun 25, 2024

Why are these changes needed?

  1. Sending protobufs requires repeating same boiler plate code
  2. Support for non-color console logging

Related issue number

Checks

@rajan-chari rajan-chari changed the title Convenience methods for protobuf and some minor refactoring Jul 13, 2024
@sonichi sonichi requested review from thinkall and Wenyueh July 13, 2024 22:58
@sonichi sonichi enabled auto-merge July 13, 2024 23:04
Copy link
Collaborator

@thinkall thinkall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @rajan-chari ! I've just two tiny comments.

Below code:

1) Start Assistant (python demo/standalone/assistant.py)

python demo/standalone/assistant.py should be python demo/standalone/Assistant.py

samples/apps/cap/py/pyproject.toml Show resolved Hide resolved
Copy link
Collaborator

@qingyun-wu qingyun-wu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! @rajan-chari It is good to go once Li's comment is addressed! Thanks!

Copy link

gitguardian bot commented Jul 20, 2024

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them.
Once a secret has been leaked into a git repository, you should consider it compromised, even if it was deleted immediately.
Find here more information about risks.


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@sonichi sonichi added this pull request to the merge queue Jul 23, 2024
Merged via the queue into microsoft:main with commit b7bdbe1 Jul 23, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants