-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update method name in GeminiClient #3007
Conversation
- change from `_initialize_vartexai` to `_initialize_vertexai`
@sugatoray Thanks for fixing the typo!~ |
@BeibinLi I see the tests are failing for a different reason apparently. Can you please go ahead and merge the PR if it looks okay to you? |
once the LLamaIndexAgent tests are fixed we'll merge this PR. thanks |
️✅ There are no secrets present in this pull request anymore.If these secrets were true positive and are still valid, we highly recommend you to revoke them. 🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request. |
@BeibinLi can you approve the PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @sugatoray.
GeminiClient
method name from_initialize_vartexai
to_initialize_vertexai
.vartexai
is a typo. It should bevertextai
instead. This PR fixes that.Checks
NA