Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update method name in GeminiClient #3007

Merged
merged 2 commits into from
Jul 21, 2024

Conversation

sugatoray
Copy link
Contributor

@sugatoray sugatoray commented Jun 24, 2024

  • Change GeminiClient method name from _initialize_vartexai to _initialize_vertexai.
  • Why? vartexai is a typo. It should be vertextai instead. This PR fixes that.

Checks

- change from `_initialize_vartexai` to `_initialize_vertexai`
@sugatoray sugatoray marked this pull request as ready for review June 24, 2024 08:35
@Hk669 Hk669 requested a review from BeibinLi June 24, 2024 16:14
@BeibinLi
Copy link
Collaborator

@sugatoray Thanks for fixing the typo!~

@sugatoray
Copy link
Contributor Author

sugatoray commented Jun 24, 2024

@BeibinLi I see the tests are failing for a different reason apparently. Can you please go ahead and merge the PR if it looks okay to you?

@BeibinLi BeibinLi enabled auto-merge June 24, 2024 23:14
@Hk669
Copy link
Collaborator

Hk669 commented Jun 25, 2024

@BeibinLi I see the tests are failing for a different reason apparently. Can you please go ahead and merge the PR if it looks okay to you?

once the LLamaIndexAgent tests are fixed we'll merge this PR. thanks

Copy link

gitguardian bot commented Jul 20, 2024

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them.
Once a secret has been leaked into a git repository, you should consider it compromised, even if it was deleted immediately.
Find here more information about risks.


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@Hk669
Copy link
Collaborator

Hk669 commented Jul 21, 2024

@BeibinLi can you approve the PR.

@Hk669 Hk669 self-requested a review July 21, 2024 05:07
Copy link
Collaborator

@Hk669 Hk669 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @sugatoray.

@BeibinLi BeibinLi added this pull request to the merge queue Jul 21, 2024
Merged via the queue into microsoft:main with commit 2887e07 Jul 21, 2024
137 of 151 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants