Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(client-test-utils): prevent malformed TimeoutWithValue use #21817

Merged
merged 1 commit into from
Jul 10, 2024
Merged

fix(client-test-utils): prevent malformed TimeoutWithValue use #21817

merged 1 commit into from
Jul 10, 2024

Conversation

jason-ha
Copy link
Contributor

@jason-ha jason-ha commented Jul 10, 2024 •
edited
Loading

without reject: false since TimeoutWithError would allow any object
@jason-ha
fix(client-test-utils): prevent malformed TimeoutWithValue use
f400ac5 
without `reject: false` since TimeoutWithError would allow an object
@github-actions github-actions bot added area: tests Tests to add, test infrastructure improvements, etc base: main PRs targeted against main branch labels Jul 10, 2024
@msfluid-bot
Copy link
Collaborator

⯅ @fluid-example/bundle-size-tests: +245 Bytes
Metric NameBaseline SizeCompare SizeSize Diff
aqueduct.js 456.49 KB 456.53 KB ⯅ +35 Bytes
azureClient.js 554.23 KB 554.28 KB ⯅ +49 Bytes
connectionState.js 680 Bytes 680 Bytes ■ No change
containerRuntime.js 257.7 KB 257.72 KB ⯅ +14 Bytes
fluidFramework.js 391.41 KB 391.43 KB ⯅ +14 Bytes
loader.js 134.1 KB 134.11 KB ⯅ +14 Bytes
map.js 42.17 KB 42.17 KB ⯅ +7 Bytes
matrix.js 145.43 KB 145.44 KB ⯅ +7 Bytes
odspClient.js 522.23 KB 522.28 KB ⯅ +49 Bytes
odspDriver.js 97.17 KB 97.19 KB ⯅ +21 Bytes
odspPrefetchSnapshot.js 42.27 KB 42.29 KB ⯅ +14 Bytes
sharedString.js 162.51 KB 162.52 KB ⯅ +7 Bytes
sharedTree.js 381.87 KB 381.88 KB ⯅ +7 Bytes
Total Size 3.26 MB 3.26 MB ⯅ +245 Bytes

Baseline commit: 704083b

Generated by 🚫 dangerJS against f400ac5

@jason-ha jason-ha requested a review from WillieHabi July 10, 2024 07:18
WillieHabi
WillieHabi approved these changes Jul 10, 2024
View reviewed changes
Copy link
Contributor

@WillieHabi WillieHabi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍
@jason-ha jason-ha merged commit fff062f into microsoft:main Jul 10, 2024
32 checks passed
@jason-ha jason-ha deleted the fix-test-utils-malformed-timeout-option-allowance branch July 10, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: tests Tests to add, test infrastructure improvements, etc base: main PRs targeted against main branch
3 participants
@jason-ha @msfluid-bot @WillieHabi