-
Notifications
You must be signed in to change notification settings - Fork 523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Add stage to E2E pipeline to run bug creation script #21816
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few comments but I think it's the right direction. About how to test it, what you'll want to do is push these same changes to a test/ branch in the microsoft repo (instead of your fork). Then do a manual run of build - client packages in the internal project targeting that test/ branch, and once that one completes, manually run the e2e tests pipeline also pointing to the test/ branch, and pointing to the build - client run that just finished as well. We can sync up tomorrow if you need more details on the steps.
- checkout: ff_internal | ||
displayName: 'Fluid Framework internal repository' | ||
persistCredentials: true | ||
repository: 'https://dev.azure.com/fluidframework/internal/_git/ff_internal' | ||
clean: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indentation here seems to have an issue, I think all the keys need to align with checkout
instead of with the dash.
PROJECT: ${{ variables.project }} | ||
inputs: | ||
targetType: 'inline' | ||
workingDirectory |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we need a working directory specified here, since apparently we can just point to the absolute path of the bug creation script when invoking node like you're doing right now. I can't tell just by looking at line 263 if it's correct or not, but seems promising to me. I'd imagine the identifier we gave to the checkout
step on line 245 might be the folder name it uses under Build.SourcesDirectory to clone that repo.
ORGANIZATION: ${{ variables.organization }} | ||
PROJECT: ${{ variables.project }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd say just bring the values inline here, they're not being used in several places in the pipeline so might as well make this task super self-contained and understandable without having to scroll through the file.
Closing this PR and moving it to #21825 |
AB#8482
Description
This PR adds a stage to the End to End pipeline. The new stage runs a script which takes the failing tests in the build and creates/updates ADO work items
Notes: