improvement(eslint-config-fluid): Disable unicorn/prefer-module for tests
#21814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: build
tylerbutler
reviewed
Jul 11, 2024
Comment on lines
+11
to
+13
| - The following rules have been disabled for test code: | ||
|
|
||
| - [unicorn/prefer-module](https://github.com/sindresorhus/eslint-plugin-unicorn/blob/v48.0.1/docs/rules/prefer-module.md) |
There was a problem hiding this comment.
Suggested change
| - The following rules have been disabled for test code: | |
| - [unicorn/prefer-module](https://github.com/sindresorhus/eslint-plugin-unicorn/blob/v48.0.1/docs/rules/prefer-module.md) | |
| The following rules have been disabled for test code: | |
| - [unicorn/prefer-module](https://github.com/sindresorhus/eslint-plugin-unicorn/blob/v48.0.1/docs/rules/prefer-module.md) |
There was a problem hiding this comment.
Sorry, had autocomplete set for this. I'll do a follow-up PR to fix the formatting.
tylerbutler
approved these changes
Jul 11, 2024
Josmithr
added a commit
that referenced
this pull request
Jul 11, 2024
Bad formatting was introduced in #21814
RishhiB
pushed a commit
to RishhiB/FluidFramework-1
that referenced
this pull request
Jul 18, 2024
Bad formatting was introduced in microsoft#21814
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We run most of our tests in a Node.js environment, so this rule is not important and makes file-system logic more cumbersome.