Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tree: type tests tree public API #21789

Merged
merged 5 commits into from
Jul 10, 2024

Conversation

CraigMacomber
Copy link
Contributor

Description

With the recent type test fixes, tree's public API can be type tested.

This enables those type tests.

Reviewer Guidance

The review process is outlined on this wiki page.

@CraigMacomber CraigMacomber requested a review from a team as a code owner July 8, 2024 21:26
@github-actions github-actions bot added area: dds Issues related to distributed data structures area: dds: tree dependencies Pull requests that update a dependency file base: main PRs targeted against main branch labels Jul 8, 2024
@msfluid-bot
Copy link
Collaborator

msfluid-bot commented Jul 8, 2024

@fluid-example/bundle-size-tests: +245 Bytes
Metric NameBaseline SizeCompare SizeSize Diff
aqueduct.js 456.49 KB 456.53 KB +35 Bytes
azureClient.js 554.23 KB 554.28 KB +49 Bytes
connectionState.js 680 Bytes 680 Bytes No change
containerRuntime.js 257.7 KB 257.72 KB +14 Bytes
fluidFramework.js 391.41 KB 391.43 KB +14 Bytes
loader.js 134.1 KB 134.11 KB +14 Bytes
map.js 42.17 KB 42.17 KB +7 Bytes
matrix.js 145.43 KB 145.44 KB +7 Bytes
odspClient.js 522.23 KB 522.28 KB +49 Bytes
odspDriver.js 97.17 KB 97.19 KB +21 Bytes
odspPrefetchSnapshot.js 42.27 KB 42.29 KB +14 Bytes
sharedString.js 162.51 KB 162.52 KB +7 Bytes
sharedTree.js 381.87 KB 381.88 KB +7 Bytes
Total Size 3.26 MB 3.26 MB +245 Bytes

Baseline commit: fff062f

Generated by 🚫 dangerJS against 5880230

@CraigMacomber CraigMacomber merged commit 2e79695 into microsoft:main Jul 10, 2024
30 checks passed
@CraigMacomber CraigMacomber deleted the type-test-tree branch July 10, 2024 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: dds: tree area: dds Issues related to distributed data structures base: main PRs targeted against main branch dependencies Pull requests that update a dependency file
3 participants