Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Prototype] NoOp container message type #21747

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dannimad
Copy link
Contributor

@dannimad dannimad commented Jul 2, 2024

Solves AB#8283
We need a way to catch whenever a batch becomes empty on resubmission. The "NoOp" message type is intended to accomplish that by being sent in case we have offline load enabled and we try tu resubmit an empty batch.
There's still an optimization to be made about just catching the case where the batch "becomes" empty on resubmt instead just "being" empty in the first place.

@github-actions github-actions bot added area: loader Loader related issues area: runtime Runtime related issues public api change Changes to a public API base: main PRs targeted against main branch labels Jul 2, 2024
@msfluid-bot
Copy link
Collaborator

@fluid-example/bundle-size-tests: +2.56 KB
Metric NameBaseline SizeCompare SizeSize Diff
aqueduct.js 455.58 KB 456.13 KB +561 Bytes
azureClient.js 553.18 KB 553.83 KB +667 Bytes
connectionState.js 680 Bytes 680 Bytes No change
containerRuntime.js 256.89 KB 257.42 KB +540 Bytes
fluidFramework.js 385.11 KB 385.13 KB +14 Bytes
loader.js 134.01 KB 134.11 KB +104 Bytes
map.js 42.17 KB 42.17 KB +7 Bytes
matrix.js 145.44 KB 145.45 KB +7 Bytes
odspClient.js 520.97 KB 521.62 KB +665 Bytes
odspDriver.js 96.94 KB 96.96 KB +21 Bytes
odspPrefetchSnapshot.js 42.23 KB 42.24 KB +14 Bytes
sharedString.js 162.52 KB 162.53 KB +7 Bytes
sharedTree.js 375.58 KB 375.58 KB +7 Bytes
Total Size 3.25 MB 3.25 MB +2.56 KB

Baseline commit: 8b542d3

Generated by 🚫 dangerJS against f06879f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: loader Loader related issues area: runtime Runtime related issues base: main PRs targeted against main branch public api change Changes to a public API
2 participants