Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement memory usage test for SharedTree #21737

Merged
merged 35 commits into from
Jul 11, 2024
Merged

Implement memory usage test for SharedTree #21737

merged 35 commits into from
Jul 11, 2024

Conversation

jikim-msft
Copy link
Contributor

@jikim-msft jikim-msft commented Jul 1, 2024 •
edited
Loading

Description

7832

This PR implements tests that measure memory usage/pressure for SharedTree's public API.
@github-actions github-actions bot added area: dds Issues related to distributed data structures area: dds: tree base: main PRs targeted against main branch labels Jul 1, 2024
@jikim-msft jikim-msft changed the title Shared tree/memory test Jul 2, 2024
@jikim-msft jikim-msft requested a review from alexvy86 July 2, 2024 23:49
alexvy86
alexvy86 reviewed Jul 3, 2024
View reviewed changes
packages/dds/tree/src/test/memory/.mocharc.cjs Outdated Show resolved Hide resolved
packages/dds/tree/src/test/memory/.mocharc.cjs Outdated Show resolved Hide resolved
packages/dds/tree/src/test/memory/tree.spec.ts Outdated Show resolved Hide resolved
packages/dds/tree/src/test/memory/tree.spec.ts Outdated Show resolved Hide resolved
packages/dds/tree/src/test/memory/tree.spec.ts Outdated Show resolved Hide resolved
packages/dds/tree/src/test/memory/tree.spec.ts Outdated Show resolved Hide resolved
packages/dds/tree/src/test/memory/tree.spec.ts Show resolved Hide resolved
jikim-msft and others added 7 commits July 3, 2024 11:02
@jikim-msft @alexvy86
Update packages/dds/tree/src/test/memory/.mocharc.cjs
b154be9 
Co-authored-by: Alex Villarreal <716334+alexvy86@users.noreply.github.com>
@jikim-msft @alexvy86
Update packages/dds/tree/src/test/memory/tree.spec.ts
fc2c592 
Co-authored-by: Alex Villarreal <716334+alexvy86@users.noreply.github.com>
@jikim-msft @alexvy86
Update packages/dds/tree/src/test/memory/tree.spec.ts
984823e 
Co-authored-by: Alex Villarreal <716334+alexvy86@users.noreply.github.com>
@jikim-msft
remove empty sharedtree
7747499
@jikim-msft
fix mocha / remove sample count
c4850a1
@jikim-msft
add map / optional
5c8eba1
@jikim-msft
make sharedTree undefined
1f47ab7
@jikim-msft jikim-msft requested a review from Abe27342 July 8, 2024 21:10
@jikim-msft jikim-msft marked this pull request as ready for review July 8, 2024 22:03
@jikim-msft jikim-msft requested a review from a team as a code owner July 8, 2024 22:03
@jikim-msft jikim-msft requested a review from alexvy86 July 8, 2024 23:18
@msfluid-bot
Copy link
Collaborator

msfluid-bot commented Jul 9, 2024 •
edited
Loading

⯅ @fluid-example/bundle-size-tests: +245 Bytes
Metric NameBaseline SizeCompare SizeSize Diff
aqueduct.js 457.12 KB 457.16 KB ⯅ +35 Bytes
azureClient.js 555.1 KB 555.14 KB ⯅ +49 Bytes
connectionState.js 680 Bytes 680 Bytes ■ No change
containerRuntime.js 258.33 KB 258.35 KB ⯅ +14 Bytes
fluidFramework.js 391.41 KB 391.43 KB ⯅ +14 Bytes
loader.js 134.1 KB 134.11 KB ⯅ +14 Bytes
map.js 42.17 KB 42.17 KB ⯅ +7 Bytes
matrix.js 145.43 KB 145.44 KB ⯅ +7 Bytes
odspClient.js 522.86 KB 522.91 KB ⯅ +49 Bytes
odspDriver.js 97.17 KB 97.19 KB ⯅ +21 Bytes
odspPrefetchSnapshot.js 42.27 KB 42.29 KB ⯅ +14 Bytes
sharedString.js 162.51 KB 162.52 KB ⯅ +7 Bytes
sharedTree.js 381.87 KB 381.88 KB ⯅ +7 Bytes
Total Size 3.26 MB 3.27 MB ⯅ +245 Bytes

Baseline commit: 4fc277a

Generated by 🚫 dangerJS against 186f2a3

alexvy86
alexvy86 approved these changes Jul 11, 2024
View reviewed changes
Copy link
Contributor

@alexvy86 alexvy86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment below, and the one I sent on chat about lowering the timeouts if possible. Other than that, lgtm.
packages/dds/tree/src/test/memory/tree.spec.ts Outdated Show resolved Hide resolved
@jikim-msft jikim-msft enabled auto-merge (squash) July 11, 2024 21:38
@jikim-msft jikim-msft requested a review from Abe27342 July 11, 2024 21:49
@jikim-msft jikim-msft merged commit 419f8e9 into microsoft:main Jul 11, 2024
30 checks passed
@jikim-msft jikim-msft deleted the shared-tree/memory-test branch July 12, 2024 21:03
RishhiB pushed a commit to RishhiB/FluidFramework-1 that referenced this pull request Jul 18, 2024
@jikim-msft @alexvy86 @RishhiB
Implement memory usage test for SharedTree (microsoft#21737)
ab2225d 
#### Description


[7832](https://dev.azure.com/fluidframework/internal/_workitems/edit/7832/)

This PR implements tests that measure memory usage/pressure for
SharedTree's public API.

---------

Co-authored-by: Alex Villarreal <716334+alexvy86@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: dds: tree area: dds Issues related to distributed data structures base: main PRs targeted against main branch
4 participants
@jikim-msft @msfluid-bot @alexvy86 @Abe27342