Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable noUncheckedIndexedAccess for Tree #21672

Merged
merged 50 commits into from
Jul 22, 2024
Merged

Enable noUncheckedIndexedAccess for Tree #21672

merged 50 commits into from
Jul 22, 2024

Conversation

RishhiB
Copy link
Contributor

@RishhiB RishhiB commented Jun 27, 2024 •
edited
Loading

Enable noUncheckedIndexedAccess for Tree
We are enabling noUncheckedIndexedAccess to protect us from changing a type of a record where there was a named property and reduce the risk of runtime errors by ensuring that indexed access on objects are properly checked for undefined values.

Arrays are impacted by this and must be annotated even though it is not the reason for using the setting

AB#8216
@github-actions github-actions bot added area: dds Issues related to distributed data structures area: dds: tree base: main PRs targeted against main branch labels Jun 27, 2024
@msfluid-bot
Copy link
Collaborator

msfluid-bot commented Jun 27, 2024 •
edited
Loading

⯅ @fluid-example/bundle-size-tests: +2.5 KB
Metric NameBaseline SizeCompare SizeSize Diff
aqueduct.js 457.46 KB 457.5 KB ⯅ +35 Bytes
azureClient.js 555.23 KB 555.28 KB ⯅ +49 Bytes
connectionState.js 680 Bytes 680 Bytes ■ No change
containerRuntime.js 258.67 KB 258.68 KB ⯅ +14 Bytes
fluidFramework.js 405.94 KB 407.08 KB ⯅ +1.14 KB
loader.js 134.04 KB 134.05 KB ⯅ +14 Bytes
map.js 42.13 KB 42.14 KB �� +7 Bytes
matrix.js 145.61 KB 145.62 KB ⯅ +7 Bytes
odspClient.js 523.37 KB 523.42 KB ⯅ +49 Bytes
odspDriver.js 97.55 KB 97.57 KB ⯅ +21 Bytes
odspPrefetchSnapshot.js 42.61 KB 42.62 KB ⯅ +14 Bytes
sharedString.js 162.62 KB 162.63 KB ⯅ +7 Bytes
sharedTree.js 396.45 KB 397.59 KB ⯅ +1.14 KB
Total Size 3.3 MB 3.3 MB ⯅ +2.5 KB

Baseline commit: 065417a

Generated by 🚫 dangerJS against b5879a3

@RishhiB RishhiB marked this pull request as ready for review July 4, 2024 16:24
@RishhiB RishhiB requested a review from a team as a code owner July 4, 2024 16:24
@RishhiB RishhiB marked this pull request as draft July 10, 2024 16:39
noencke
noencke reviewed Jul 11, 2024
View reviewed changes
packages/dds/tree/src/util/utils.ts Outdated Show resolved Hide resolved
packages/dds/tree/src/core/tree/treeTextFormat.ts Outdated Show resolved Hide resolved
packages/dds/tree/src/feature-libraries/modular-schema/modularChangeFamily.ts Outdated Show resolved Hide resolved
packages/dds/tree/src/core/rebase/utils.ts Outdated Show resolved Hide resolved
packages/dds/tree/src/core/rebase/utils.ts Outdated Show resolved Hide resolved
packages/dds/tree/src/feature-libraries/chunked-forest/uniformChunk.ts Outdated Show resolved Hide resolved
packages/dds/tree/src/feature-libraries/chunked-forest/uniformChunk.ts Outdated Show resolved Hide resolved
packages/dds/tree/src/feature-libraries/chunked-forest/uniformChunk.ts Outdated Show resolved Hide resolved
packages/dds/tree/src/feature-libraries/chunked-forest/codec/chunkCodecUtilities.ts Outdated Show resolved Hide resolved
packages/dds/tree/src/core/tree/anchorSet.ts Show resolved Hide resolved
RishhiB and others added 4 commits July 11, 2024 09:55
@RishhiB @noencke
Update packages/dds/tree/src/core/tree/treeTextFormat.ts
762e3a8 
Co-authored-by: Noah Encke <78610362+noencke@users.noreply.github.com>
@RishhiB @noencke
Update packages/dds/tree/src/core/rebase/utils.ts
733722b 
Co-authored-by: Noah Encke <78610362+noencke@users.noreply.github.com>
@RishhiB @noencke
Update packages/dds/tree/src/core/rebase/utils.ts
8e757b5 
Co-authored-by: Noah Encke <78610362+noencke@users.noreply.github.com>
@RishhiB @noencke
Update packages/dds/tree/src/feature-libraries/chunked-forest/uniform…
e525687 
…Chunk.ts

Co-authored-by: Noah Encke <78610362+noencke@users.noreply.github.com>
@github-actions github-actions bot removed documentation Improvements or additions to documentation area: loader Loader related issues area: driver Driver related issues area: dds: sharedstring labels Jul 18, 2024
RishhiB and others added 7 commits July 18, 2024 07:48
@RishhiB @noencke
Update packages/dds/tree/src/core/tree/detachedFieldIndexCodec.ts
43df9b5 
Co-authored-by: Noah Encke <78610362+noencke@users.noreply.github.com>
@RishhiB @noencke
Update packages/dds/tree/src/feature-libraries/chunked-forest/basicCh…
6c87066 
…unk.ts

Co-authored-by: Noah Encke <78610362+noencke@users.noreply.github.com>
@RishhiB @noencke
Update packages/dds/tree/src/feature-libraries/chunked-forest/basicCh…
d48bd5c 
…unk.ts

Co-authored-by: Noah Encke <78610362+noencke@users.noreply.github.com>
@RishhiB @noencke
Update packages/dds/tree/src/feature-libraries/chunked-forest/chunkTr…
2583df2 
…ee.ts

Co-authored-by: Noah Encke <78610362+noencke@users.noreply.github.com>
@RishhiB @noencke
Update packages/dds/tree/src/feature-libraries/chunked-forest/chunked…
a331dff 
…Forest.ts

Co-authored-by: Noah Encke <78610362+noencke@users.noreply.github.com>
@RishhiB
update to oob and disable non null for entire file
da4ec03
@RishhiB
more oob
3513d57
@RishhiB RishhiB marked this pull request as ready for review July 18, 2024 16:29
@RishhiB RishhiB enabled auto-merge (squash) July 18, 2024 19:12
@RishhiB RishhiB merged commit c4ee7ab into microsoft:main Jul 22, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: dds: tree area: dds Issues related to distributed data structures base: main PRs targeted against main branch
4 participants
@RishhiB @msfluid-bot @jason-ha @noencke