You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
…20026)
During the interval change codepath, many local references are created
and updated, but local references for removed interval endpoints were
never cleaned up. This was causing a bug where after removing a range of
text and reverting the remove, the interval endpoints would not return
to the position at which they were created. Some existing unit tests
also used the stale references, and these only worked in the past
because we didn't do any clean up. Those tests now use the updated
references.
[AB#7044](https://dev.azure.com/fluidframework/235294da-091d-4c29-84fc-cdfc3d90890b/_workitems/edit/7044),
#19352
---------
Co-authored-by: Scarlett Lee <90647596+scarlettjlee@users.noreply.github.com>
@amruth-ms after the above PR was checked in, are you seeing the expected behavior after you undo intervals? We kept around some references that were interfering with the repositioning of the interval after the undo. The case you described should work correctly now.
@jzaffiro thank you for the update :). It looks like the changes in the above commit did not reach our repo yet. I will verify if the bug is fixed on our end once we update our FF versions and give you an update.
Describe the bug
With the latest changes in this file(https://github.com/microsoft/FluidFramework/blob/main/packages/dds/sequence/src/revertibles.ts), the undo/redo with intervals is more flexible now. But there are a few instances where after undo-ing the intervals don't seem to be repositioned at the expected location. Below are the repro steps for one such case:
To Reproduce
Steps to reproduce the behavior:
The text was updated successfully, but these errors were encountered: