Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build 3095 compatibility #148

Open
ikt32 opened this issue Dec 18, 2023 · 38 comments
Open

Build 3095 compatibility #148

ikt32 opened this issue Dec 18, 2023 · 38 comments

Comments

@ikt32
Copy link
Owner

ikt32 commented Dec 18, 2023

Describe the bug
Multiple patches and pattern searches fail on b3095 due to extensive code changes by Rockstar.

To Reproduce
Steps to reproduce the behavior:

  • Attempt to run any current Manual Transmission version on GTA V build 3095

Expected behavior

No issues.

Additional context

I don't have time to look into this. Since Rockstar introduced a manual transmission mode in a drag race, I suspect my whole way of patching out the shifting logic won't do anymore. At the same time, there are natives available to do the shifting, so the whole manual transmission part should probably be rewritten to be fully compatible with b3095+.

@zikehalil3535
Copy link

We need an update sir, we waiting for.

@rolandwellinger
Copy link

I can also confirm that manual h-shifting and steering do not work anymore. i really hate rockstar patching such stuff for an old game people want to enjoy with mods. H-Shifting is not so importand but the wheel turning the front wheels is :). So its like written above. Steering Wheel is turning and force feedback is working. But the tires/wheels of the car do not react to the input. Im ready to donate and honorate a fix for this.

@metoxys
Copy link

metoxys commented Dec 21, 2023

At least the following memory adresses in VExt no longer work: Throttle, Brake, Steering, SteeringAngleInput

@ikt32
Copy link
Owner Author

ikt32 commented Dec 21, 2023

@metoxys
Can you attach Gears.log to a reply? I'm curious of what it all broke.

@fingaweg
Copy link
Contributor

@metoxys Can you attach Gears.log to a reply? I'm curious of what it all broke.

[ ERROR ] [Patch] Test: [Gears: Shift Up] not found
[ ERROR ] [Patch] Test: [Gears: Shift Down] not found
[ ERROR ] [Patch] Test: [Gears: Clutch Rev lim] not found
[ ERROR ] [Patch] Test: [Gears: Throttle lift] not found
[ ERROR ] [Patch] Test: [Steer: Steering input] not found
[ ERROR ] Patchability test failed!
@metoxys
Copy link

metoxys commented Dec 21, 2023

@metoxys Can you attach Gears.log to a reply? I'm curious of what it all broke.

I diagnosed this by looking at my ghostreplay output (unexpected 0.0) which also uses VExt, but fingaweg also followed through

Repository owner deleted a comment Dec 23, 2023
Repository owner deleted a comment Dec 23, 2023
Repository owner deleted a comment from JumbleBumble Dec 23, 2023
Repository owner deleted a comment Dec 23, 2023
Repository owner deleted a comment Dec 23, 2023
Repository owner deleted a comment Dec 23, 2023
Repository owner deleted a comment Dec 23, 2023
Repository owner deleted a comment from rolandwellinger Dec 23, 2023
@ikt32
Copy link
Owner Author

ikt32 commented Dec 23, 2023

With that cleaned up - please try to keep discussion on-topic for if someone else wants to pick this up. If more comments like that pop up, the most helpful thing you can do is not engage in discussion, but just to report the comment and account.

@RusLanParty
Copy link

I would gladly volunteer to fix the issue, but I don't have much experience with memory tinkering. Can you explain to me in more detail what should be done?
If I understood correctly your way of patching the memory doesn't work anymore, and instead of memory patching we now have to find a way to rewrite the whole thing using native functions?

@kagikn
Copy link
Contributor

kagikn commented Dec 23, 2023

@RusLanParty In short, the script needs other memory patterns for b3095 or later so it can change how vehicle gears behave (assembly code issues) and transmission data that aren't accessible via native functions (the latter is addressed in #153).

@metoxys Can you attach Gears.log to a reply? I'm curious of what it all broke.

[ ERROR ] [Patch] Test: [Gears: Shift Up] not found
[ ERROR ] [Patch] Test: [Gears: Shift Down] not found
[ ERROR ] [Patch] Test: [Gears: Clutch Rev lim] not found
[ ERROR ] [Patch] Test: [Gears: Throttle lift] not found
[ ERROR ] [Patch] Test: [Steer: Steering input] not found
[ ERROR ] Patchability test failed!

Without addressing the issues @fingaweg reported (the one above quoted), the script can't change how vehicle gears behave by changing some piece of assembly code about how gear stuff works in GTA5.exe on the fly. And no, we can't disable these assembly instructions with native functions, and replacing them with the nop instruction is a relatively easy and safe way to achieve the task.

@rolandwellinger
Copy link

Chill people. Let the pals do they work. Relax. I will try a workarround today by mixing the MOD with the native steering input via X-Box EMU. Will report later on. In the meantime good look with this. Sadly i cannot really help, cause i don't understand how thos asi stuff works at all. It's always magic for me what you guyes are doing. Still ready for honorate very effort. Let me know where i can donate. Mery XMAS.

@rolandwellinger
Copy link

rolandwellinger commented Dec 23, 2023

So here im again. I did a workarround with mixing my existing X360emu setup into it. For introduction. I use a very complex Joystick Mix Setup as you can see here:
https://youtu.be/DFvKCnewfLQ

The Goal there was and is to support my rotating "Revolver" Seat for GTA5. As you can see i ride all kind of vehicles. In terms of cars i always used the MOD here. And i needed no mapping to X360emu. For all the other stuff i mix various controllers via JoystickGremlin into one X360emu profile.

What i did now is to map the steering axis of my G27 also to the x360emu wich results in a mix between the MOD and the x360 Input. Forcefeedback and animation of steering wheel ist from the MOD and the command to the wheels is done by x360. It mixes good together and works at the same time. So driving feels very good. You can also adjust the curve in JoyStickGremlin to your preference. Maybe someone gets inspired to use this workarround while waiting for the mod.

You can see a short video of my workarround here:
https://youtu.be/rL32AtGPlVs

@Gtithubin
Copy link

Describe the bug Multiple patches and pattern searches fail on b3095 due to extensive code changes by Rockstar.

To Reproduce Steps to reproduce the behavior:

  • Attempt to run any current Manual Transmission version on GTA V build 3095

Expected behavior

No issues.

Additional context

I don't have time to look into this. Since Rockstar introduced a manual transmission mode in a drag race, I suspect my whole way of patching out the shifting logic won't do anymore. At the same time, there are natives available to do the shifting, so the whole manual transmission part should probably be rewritten to be fully compatible with b3095+.

Bug
Force feedback for my wheel doesn't work at all, even after downgrading the update.rpf , update2.rpf, GTA5.exe , PlayGTAV.exe and deleted the new dlcpacks introduced with the new update.

To Reproduce

  • Game updates to newest version, downgrade to version 2802, drive around and feel no force feedback in the wheel.

Expected behavior
In version 2802, feel force feedback in wheel.

Additional context
The mod is trying to output force feedback as I have the force feedback bar that shows it, but nothing outputs to my wheel, steering does work, and even assigned buttons on the wheel work, but the force feedback is gone.
I've tried to config force feedback inside the mod and many other settings but nothing seems to work, maybe there's a new file that I don't know about that needs downgrading.

@rolandwellinger
Copy link

@Gtithubin Thats very interesting, because Forcefeedback and the Steering-Wheel is working on my side. The only thing is that the output to the wheels and the manual shift isn't working.

@GttMone
Copy link

GttMone commented Dec 24, 2023

ManualTransmission Workaround Without Downgrading GTA V

For those not wanting or not being able to downgrade GTA V, you can download FiveM and host a server locally. You can follow the official guide. There are also plenty of tutorials out there (just make sure you're not watching some sketchy advertisers that promote their paid VPS). Also make sure you add the following lines to your server.cfg:

sv_enforceGameBuild 2944
sv_scriptHookAllowed 1
@ikt32
Copy link
Owner Author

ikt32 commented Jan 4, 2024

#154 was just merged, fixing the steering override patch.
Still broken are the shift up/shift down patches. Beyond that, gear ratios are wrongly offset.

@amura87516
Copy link

#154 was just merged, fixing the steering override patch. Still broken are the shift up/shift down patches. Beyond that, gear ratios are wrongly offset.

ikt32 Can you release a new build version for this update? 🙏

@Tylerl2j89
Copy link

where is the source code, i will update it.

@Tylerl2j89
Copy link

Give me a week.

@itsHazeyo
Copy link

if you enable GearboxManual and GearboxDirectShift within a vehicles strAdvancedFlags it will allow you to use rockstars built in manual mode with some down sides but i'm sure that may have something to do with it.

@Ryan556223
Copy link

How do we find/install the new commit to fix steering? I understand MT and other features dont work but I have seen people have managed to fix the sterring thru the new commit, however I cant find which file to download as they are not in the mod files to replace

@Ntimm1129
Copy link

How do we find/install the new commit to fix steering? I understand MT and other features dont work but I have seen people have managed to fix the sterring thru the new commit, however I cant find which file to download as they are not in the mod files to replace

I’m curious about this. I didn’t think there was a way to download a merged commit. Where did you see people doing that?

@brittz
Copy link

brittz commented Feb 3, 2024

Hi there. You can compile de application by downloading de repository to your pc and installing the programs in the building requirements section https://github.com/ikt32/GTAVManualTransmission?tab=readme-ov-file#building-requirements

I already did that, if you want to try.
https://drive.google.com/file/d/13si64L0UjhO_uqva0Hvc2htYfWrAp7S3/view?usp=sharing

@fingaweg
Copy link
Contributor

fingaweg commented Feb 3, 2024

Since @ikt32 implemented continuous building into the repo, you can just download the latest commit directly from GitHub:
https://github.com/ikt32/GTAVManualTransmission/actions/runs/7412568851

@NokTham
Copy link

NokTham commented Feb 14, 2024

New build works on Epic?

@fingaweg
Copy link
Contributor

New build works on Epic?

yes, it will. There is no difference between Retail/Steam/Epic game executables anymore. they were all streamlined and are identical (you could even check the CRC SHA.

@Unknown9696
Copy link

Where i can download the new version?

@waynieoaks
Copy link

Where i can download the new version?

You can compile or download the one @brittz did a few posts up:
#148 (comment)

@Unknown9696
Copy link

Thank you so much Waynieoaks! Have a nice day!

@Unknown9696
Copy link

I tested the new version but when it is in Automatic it does not change gears and when it is on Sequential from the 3rd gear it does not work anymore

@waynieoaks
Copy link

waynieoaks commented Feb 16, 2024

That's strange because the build from @brittz works for me in automatic - steering and auto gears.

EDIT: Serves me right for having different versions - my test environment was still on the old version of GTA. Will just need to wait and see if the gears issue can be solved at all.

@NokTham
Copy link

NokTham commented Feb 18, 2024

Yeah, Automatic gears don't seem to work on my end too.
Using the Epic version.

@rolandwellinger
Copy link

Thanks all for your effort. I will soon update it on my side. Still using my workarround. Im not playing GTA5 so often.

@Rick-Nasher
Copy link

Rick-Nasher commented Feb 22, 2024

Same here, on Epic version, so couldn't downgrade, with Logitech G29+pedals and gears:
No automatic gears, was stuck at 40KM/hr, but the steering at least is fixed, so drivable!

Weird thing is: before I used the broken one from 5mods, which failed at steering, but gears were working ok!
I opted for the x360CE method for steering, but it was awful, gf couldn't drive it.

I compiled the latest github clone repo, about 2 weeks ago from within VS2022 using: https://github.com/ikt32/GTAVManualTransmission.git
Never compiled C++ since the 90's and never in VS so was bit of a learning curve.
If anybody needs it (prob not round here 😉 ), I wrote down a few steps, so just ask.

@daze1msk
Copy link

@Rick-Nasher Does the shifting works or is it still the same as before?

I'm new here so it would be great if you could guide me :)

@Rick-Nasher
Copy link

@Rick-Nasher Does the shifting works or is it still the same as before?

I'm new here so it would be great if you could guide me :)

Not that new see you were here since 2022! - If not being sarcastic then I'll here from you on discord, for I don't think ikt32 wants this in his thread. 😉

@daze1msk
Copy link

@Rick-Nasher Been on github since 2022 as im studying computer science haha ;). So you want to contact me through discord?

@Rick-Nasher
Copy link

@Rick-Nasher Been on github since 2022 as im studying computer science haha ;). So you want to contact me through discord?

Not a big gamer here so never really use discord, but hey it serves the purpose. Its just a small text, I guess I could expand on it but at least all the info is in one(alsmost) place: https://discord.gg/v7yS3P2z

@ALamX
Copy link

ALamX commented Jun 21, 2024

Hi there. You can compile de application by downloading de repository to your pc and installing the programs in the building requirements section https://github.com/ikt32/GTAVManualTransmission?tab=readme-ov-file#building-requirements

I already did that, if you want to try. https://drive.google.com/file/d/13si64L0UjhO_uqva0Hvc2htYfWrAp7S3/view?usp=sharing

Any progress on the automatic gears issue on this?
Also
Bump

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment