-
Notifications
You must be signed in to change notification settings - Fork 58.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update paste-gpg-key-id.md #33799
Update paste-gpg-key-id.md #33799
Conversation
Remove the advice about a trailing '!' This definitely does not work for me on Linux with gpg and git. Leaving off the trailing '!' works perfectly however.
Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
Automatically generated comment ℹ️This comment is automatically generated and will be overwritten every time changes are committed to this branch. The table contains an overview of files in the Content directory changesYou may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.
fpt: Free, Pro, Team |
@dustinkirkland Thanks so much for opening a PR! I'll get this triaged for review ✨ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on the official git documentation, it seems as if the !
suffix is not needed. See:
However, it seems as if there are times where !
(or escaped \!
) is required to force using a specific key. See:
!
https://www.gnupg.org/documentation/manuals/gnupg/Specify-a-User-ID.htmlWhen using gpg an exclamation mark (!) may be appended to force using the specified primary or secondary key and not to try and calculate which primary or secondary key to use.
!
https://vitalii.kozlovskyi.dev/posts/gpg-hardware-key-and-git-signing/\!
https://www.hjdskes.nl/blog/psa-github-gpg/
Consequently, I'm going to expand your change to add this as an option.
I'm not sure why the preview's failing - I've tried re-running the workflow, which didn't make any difference 😞 I'm going to update this branch from |
@dustinkirkland - this has the change you suggested, but still allows people to discover the use of an Since you're based in the US and I'm in Europe, I'm going to leave this for you to take a look at the preview: Telling Git about your GPG key with the intention of merging it tomorrow unless you spot any errors or concerns. |
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡ |
The documentation in here definitively does not work -- adding a trailing exclamation mark on a subkey causes git signing to fail:
However, omitting the trailing "!" works perfectly....