Login/out block: Add example of the block #62937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
MaggieCabrera
added
[Type] Enhancement
18 tasks
|
Size Change: +7 B (0%) Total Size: 1.76 MB
ℹ️ View Unchanged
|
|
Nice, it works for me :) Is there a reason the preview isn't centrally aligned in the gray container? 🤔 |
I think it behaves the way it would when you insert he block in the canvas. Also, it's how it's on the mockup for the block in this comment |
|
Seems like it affects all previews anyway, so probably a separate issue: 
|
jameskoster
approved these changes
Jul 1, 2024
jameskoster
requested review from
a team and
luisherranz
and removed request for
a team
youknowriad
approved these changes
Jul 1, 2024
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Jul 18, 2024
* add example for the block * moved the change to block.json instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Add a basic example to the
core/loginoutblock.Part of #30029
Why?
Because it was showing empty before
How?
I define a viewport size for the example
Testing Instructions
Open the block inserter and search for the login block, hover over it and you'll see the example
Testing Instructions for Keyboard
Screenshots or screencast