Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generic name for previous version of WP tests. #62853

Merged
merged 3 commits into from
Jun 26, 2024
Merged

Conversation

peterwilsoncc
Copy link
Contributor

@peterwilsoncc peterwilsoncc commented Jun 26, 2024

What?

Modifies the job name for running the PHP Unit tests against the previous version of WordPress to be version agnostic.

Instead of being named PHP x.x (WP x.x.x)... they are named PHP x.x (WP previous major version)...

Why?

Each time a new version of WordPress is released, the list of required actions in this repo's settings become out of date and need to be updated. This causes expected jobs to fail to report on pull requests, stalling the potential for merging.

Warning

After merge, this will require updating the list of expected jobs in the settings.

The goal is that this will be the last time this is required.

How?

Replaces the WordPress matrix version number with previous major version and determines what that is when setting the WP_ENV_CORE environment variable.

Debug information is added to the docker containers to run wp core version and log the version being tested to the logs.

Testing Instructions

  1. Review the Unit tests job (Click Checks > Unit Tests)
  2. Ensure the jobs title PHP Unit tests previous major version are running the previous major version
  3. Once a previous major version of WP receives a version bump, confirm that the version is bumped in the unit tests.

Testing Instructions for Keyboard

N/A

Screenshots or screencast

@peterwilsoncc peterwilsoncc marked this pull request as ready for review June 26, 2024 02:54
Copy link

github-actions bot commented Jun 26, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: peterwilsoncc <peterwilsoncc@git.wordpress.org>
Co-authored-by: talldan <talldanwp@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@peterwilsoncc peterwilsoncc added the [Type] Build Tooling Issues or PRs related to build tooling label Jun 26, 2024
@peterwilsoncc peterwilsoncc self-assigned this Jun 26, 2024
Copy link
Contributor

@talldan talldan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing this, the changes look good to me. The version can still be checked in the log output. I'll approve/merge this now and update the required checks.

@talldan talldan merged commit 913ebe0 into trunk Jun 26, 2024
66 of 68 checks passed
@talldan talldan deleted the try/unit-test-matrix branch June 26, 2024 07:04
@github-actions github-actions bot added this to the Gutenberg 18.7 milestone Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Build Tooling Issues or PRs related to build tooling
2 participants