Show publish panel only in edit mode #62813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
added
[Type] Bug
ntsekouras
requested review from
youknowriad,
oandregal,
ellatrix,
carolinan and
t-hamano
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -197 B (-0.01%) Total Size: 1.76 MB
ℹ️ View Unchanged
|
youknowriad
reviewed
Jun 25, 2024
youknowriad
reviewed
Jun 25, 2024
youknowriad
approved these changes
Jun 25, 2024
t-hamano
reviewed
Jun 25, 2024
There was a problem hiding this comment.
Thanks for the PR!
Not a blocker, but from what I understand, this PR fixes part of #62702. There is another problem with #62702:
The following issue occurs whether the canvas is in view or edit mode.
- Open any template.
- Click the tab key repeatedly to move focus to the "Open puglish panel" button.
- Click that button.
- The Publish panel appears.
- URL is undefined.
- Copy button doesn't work.
- The 'View Template' button doesn't work.
- Clicking the 'Add New Template' button shows an error.
ellatrix
added
Backport to WP 6.6 Beta/RC
and removed
Backport to WP 6.6 Beta/RC
gutenbergplugin
pushed a commit
that referenced
this pull request
Jun 25, 2024
Co-authored-by: ntsekouras <ntsekouras@git.wordpress.org> Co-authored-by: youknowriad <youknowriad@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org>
github-actions
bot
added
the
Backported to WP Core
|
I just cherry-picked this PR to the wp/6.6 branch to get it included in the next release: f3deff5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes: #62702
This PR fixes that by only rendering this when we're in edit mode, which is the default for post editor.
Testing Instructions
tabkey you shouldn't be able to reproduce this:22abfebc1fb8e777bcf3a0e57fd19a4d.mp4
tabkey in post editor should work as before and show theopen publish panelbutton.