Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add changelog entry for splitTask export from @wordpress/interactivity #62805

Merged
merged 2 commits into from
Jun 25, 2024
Merged

Add changelog entry for splitTask export from @wordpress/interactivity #62805

merged 2 commits into from
Jun 25, 2024

Conversation

westonruter
Copy link
Member

@westonruter westonruter requested review from DAreRodz and removed request for DAreRodz June 24, 2024 19:41
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 24, 2024 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: westonruter <westonruter@git.wordpress.org>
Co-authored-by: cbravobernal <cbravobernal@git.wordpress.org>
Co-authored-by: luisherranz <luisherranz@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.
@westonruter westonruter mentioned this pull request Jun 24, 2024
Merged
@westonruter westonruter added the [Type] Developer Documentation Documentation for developers label Jun 24, 2024
cbravobernal
cbravobernal previously requested changes Jun 24, 2024
View reviewed changes
Copy link
Contributor

@cbravobernal cbravobernal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the changelog!

Changes should be under ## Unreleased heading. Once packages are released it will auto-update to its correspondant version.
packages/interactivity/CHANGELOG.md Outdated Show resolved Hide resolved
packages/interactivity/CHANGELOG.md Outdated Show resolved Hide resolved
@westonruter @cbravobernal
Move changelog entry to Unreleased section
7ddf484 
Co-authored-by: Carlos Bravo <37012961+cbravobernal@users.noreply.github.com>
luisherranz
luisherranz approved these changes Jun 25, 2024
View reviewed changes
Copy link
Member

@luisherranz luisherranz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thank you!
@luisherranz luisherranz dismissed cbravobernal’s stale review June 25, 2024 07:05

The change was done.

@luisherranz luisherranz merged commit 1ba8018 into trunk Jun 25, 2024
62 checks passed
@luisherranz luisherranz deleted the add/splittask-changelog-entry branch June 25, 2024 07:05
@github-actions github-actions bot added this to the Gutenberg 18.7 milestone Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Developer Documentation Documentation for developers
3 participants
@westonruter @luisherranz @cbravobernal