Move Sticky toggle to status popover #62782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameskoster
added
[Type] Enhancement
|
Size Change: +2.25 kB (+0.13%) Total Size: 1.76 MB
ℹ️ View Unchanged
|
jasmussen
approved these changes
Jun 24, 2024
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
t-hamano
reviewed
Jun 24, 2024
|
Thanks for the excellent feedback, as always! :) |
|
I fixed one of the failures in the E2E tests. The error was happening here: This test verifies that the summary panel can be hidden programmatically. b259d27db9e84c6102cd332b7bbf9bdf.mp4Whether the summary panel disappears depends on whether the Sticky toggle disappears. However, since the Sticky toggle is gone, I changed it to check that the Author button disappears instead.
|
t-hamano
reviewed
Jun 24, 2024
|
Flaky tests detected in 1aa1547. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/9646411894
|
ntsekouras
approved these changes
Jun 25, 2024
|
@ntsekouras Additionally, I fixed typos. |
Oh.. so sorry about that.. Thank you! |
|
Thanks y'all! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Move the 'Sticky' toggle to the 'Status & visibility' popover in the post editing UX.
Why?
Testing Instructions