Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add letter spacing inheritance for the navigation block #62745

Merged

Conversation

graylaurenm
Copy link
Contributor

What?

Adds inheritance of letter spacing for the navigation block.

Why?

The navigation block uses inherit definitions to support typography styles. The letter-spacing definition is missing.

How?

Adds the necessary line.

Testing Instructions

<!-- wp:navigation {"ref":60591,"style":{"typography":{"letterSpacing":"0.1em"}}} /-->

Testing Instructions for Keyboard

N/A

Screenshots or screencast

Before:
Screenshot 2024-06-21 at 9 03 03 AM

After:
Screenshot 2024-06-21 at 9 03 11 AM

Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @graylaurenm.

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Unlinked contributors: graylaurenm.


To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Jun 21, 2024
Copy link

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @graylaurenm! In case you missed it, we'd love to have you join us in our Slack community.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@talldan talldan added [Block] Navigation Affects the Navigation Block [Type] Bug An existing feature does not function as intended labels Jun 24, 2024
Copy link
Contributor

@talldan talldan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @graylaurenm! The fix looks good to me.

For anyone testing, you have to set Submenus > 'Open on click' in the navigation block's settings to notice the bug. When you do that, letter spacing doesn't affect the submenu button.

@talldan talldan added the Backport to WP 6.6 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta label Jun 24, 2024
@talldan talldan merged commit 4e0d0dc into WordPress:trunk Jun 24, 2024
66 of 68 checks passed
@github-actions github-actions bot added this to the Gutenberg 18.7 milestone Jun 24, 2024
ellatrix pushed a commit that referenced this pull request Jun 25, 2024
Unlinked contributors: graylaurenm.

Co-authored-by: talldan <talldanwp@git.wordpress.org>
@ellatrix
Copy link
Member

I just cherry-picked this PR to the wp/6.6-rc-1 branch to get it included in the next release: 88002da

@ellatrix ellatrix added Backported to WP Core Pull request that has been successfully merged into WP Core and removed Backport to WP 6.6 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta labels Jun 25, 2024
ellatrix pushed a commit that referenced this pull request Jun 25, 2024
Unlinked contributors: graylaurenm.

Co-authored-by: talldan <talldanwp@git.wordpress.org>
@graylaurenm graylaurenm deleted the navigation-block-letter-spacing branch July 5, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backported to WP Core Pull request that has been successfully merged into WP Core [Block] Navigation Affects the Navigation Block First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository [Type] Bug An existing feature does not function as intended
3 participants