Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github PHP changes workflow: remove it #62609

Merged
merged 1 commit into from
Jun 17, 2024
Merged

Conversation

ramonjd
Copy link
Member

@ramonjd ramonjd commented Jun 17, 2024

Removing the PHP changes workflow

Why?

The PHP detections action checks for PHP changes and adds a comment to ask whether a backport is necessary.

Example:

Screenshot 2024-06-17 at 11 28 08 AM

I think it's just noise now that the check backport changelog workflow is in place.

Also to reduce clutter.

@ramonjd ramonjd added the [Type] Build Tooling Issues or PRs related to build tooling label Jun 17, 2024
@ramonjd ramonjd self-assigned this Jun 17, 2024
@ramonjd ramonjd requested a review from desrosj as a code owner June 17, 2024 01:28
@noisysocks
Copy link
Member

Looks good to me unless anyone in @WordPress/gutenberg-core has any objections 👍

Copy link

github-actions bot commented Jun 17, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: ramonjd <ramonopoly@git.wordpress.org>
Co-authored-by: tellthemachines <isabel_brison@git.wordpress.org>
Co-authored-by: noisysocks <noisysocks@git.wordpress.org>
Co-authored-by: ellatrix <ellatrix@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link
Contributor

@tellthemachines tellthemachines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense, thanks for the cleanup!

@ellatrix
Copy link
Member

No objections, if you think the failing test is enough. I was wondering if the backport log test should leave an actual Github comment instead, though there should be a clear error message if you open the test results.

@ramonjd ramonjd force-pushed the remove/php-detection-workflow branch from a84af57 to c5bd1de Compare June 17, 2024 07:52
@ramonjd ramonjd enabled auto-merge (squash) June 17, 2024 07:52
Copy link

Flaky tests detected in c5bd1de.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/9543945900
📝 Reported issues:

@ramonjd ramonjd merged commit 0590511 into trunk Jun 17, 2024
60 checks passed
@ramonjd ramonjd deleted the remove/php-detection-workflow branch June 17, 2024 08:27
@github-actions github-actions bot added this to the Gutenberg 18.7 milestone Jun 17, 2024
huubl pushed a commit to huubl/gutenberg that referenced this pull request Jun 17, 2024
Co-authored-by: ramonjd <ramonopoly@git.wordpress.org>
Co-authored-by: tellthemachines <isabel_brison@git.wordpress.org>
Co-authored-by: noisysocks <noisysocks@git.wordpress.org>
Co-authored-by: ellatrix <ellatrix@git.wordpress.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Build Tooling Issues or PRs related to build tooling
4 participants