Improve performance of compute_style_properties method.

[spacedmonkey]

Improve logic in compute_style_properties to improve performance. This commit fixes a number of performance issues including.

• Expensive repeated call to str_starts_with.
• Return easy if not array.
• Repeated call to strlen.
• Move call to get_property_value where it is needed.
• Move call to implode to after empty check.

What?

Why?

Before

After

How?

Testing Instructions

Testing Instructions for Keyboard

Screenshots or screencast

[github-actions]

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @jonnynews.

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Unlinked contributors: jonnynews.

Co-authored-by: spacedmonkey <spacedmonkey@git.wordpress.org>
Co-authored-by: joemcgill <joemcgill@git.wordpress.org>
Co-authored-by: tellthemachines <isabel_brison@git.wordpress.org>
Co-authored-by: ellatrix <ellatrix@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

[github-actions]

This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress.

If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core GitHub repository soon after this pull request is merged.

If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack.

Thank you! ❤️

View changed files

❔ lib/class-wp-theme-json-gutenberg.php

[joemcgill]

This looks like a good refactor to me. Left a couple of comments inline.

[github-actions]

Flaky tests detected in eca89a5.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/9512834878
📝 Reported issues:

• [Flaky Test] Redirection after template creation #60678 in /test/e2e/specs/site-editor/site-editor-url-navigation.spec.js

[ellatrix]

The Backport to WP Beta/RC label can be removed here since this will need to be backported manually, not through packages. Once a backport PR is made, add a changelog entry for 6.6 and we'll keep track of it that way.

[spacedmonkey]

The Backport to WP Beta/RC label can be removed here since this will need to be backported manually, not through packages. Once a backport PR is made, add a changelog entry for 6.6 and we'll keep track of it that way.

That is not how that works. All PRs that need to be manaully ported over, have that label assigned and are added the backport issue. Has this been changed? Where is that documented?

[ellatrix]

Sure, it's fine to leave the label. Most important is that there's a core PR.

[spacedmonkey]

Core PR WordPress/wordpress-develop#6707. Will update and commit once this PR is merged.

[ellatrix]

I just cherry-picked this PR to the wp/6.6-rc-1 branch to get it included in the next release: 1116c38

[ellatrix]

Why did you merge this with failing tests? A backport changelog entry should have been added for this PR