Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ExcerptPanel decode issue #62336

Merged
merged 1 commit into from
Jun 20, 2024
Merged

Conversation

itzmekhokan
Copy link
Contributor

Fixes #62335

What?

In the Site Editor, it displays the page title as part of the template description in the Template panel in the Site Editor Sidebar. This PR will fix the HTML entities decode, for example, a template for a page called
"Hello World & Hello WP" Would show the description: "Template for Hello World & Hello WP". After applying this patch this issue will resolved.

Screenshots or screencast

Before

template-description

After

Screenshot 2024-06-05 at 6 42 25 PM
Copy link

github-actions bot commented Jun 5, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: itzmekhokan <khokansardar@git.wordpress.org>
Co-authored-by: ntsekouras <ntsekouras@git.wordpress.org>
Co-authored-by: talldan <talldanwp@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@Mamaduka Mamaduka requested a review from ntsekouras June 5, 2024 14:57
@Mamaduka Mamaduka added [Type] Bug An existing feature does not function as intended [Feature] Document Settings Document settings experience labels Jun 5, 2024
@ellatrix ellatrix added the Backport to WP 6.6 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta label Jun 7, 2024
Copy link
Contributor

@ntsekouras ntsekouras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@ntsekouras ntsekouras changed the title Fix site editor template panel description decode issue Jun 7, 2024
@ntsekouras ntsekouras enabled auto-merge (squash) June 7, 2024 09:27
@ntsekouras ntsekouras changed the title Fix ExcerptPanel description decode issue Jun 7, 2024
@talldan
Copy link
Contributor

talldan commented Jun 20, 2024

I've rebased the branch on trunk to try to solve the failing CI tests.

@talldan talldan disabled auto-merge June 20, 2024 07:55
@talldan talldan enabled auto-merge (squash) June 20, 2024 07:55
@talldan talldan merged commit bb79514 into WordPress:trunk Jun 20, 2024
59 checks passed
@github-actions github-actions bot added this to the Gutenberg 18.7 milestone Jun 20, 2024
ellatrix pushed a commit that referenced this pull request Jun 25, 2024
Co-authored-by: itzmekhokan <khokansardar@git.wordpress.org>
Co-authored-by: ntsekouras <ntsekouras@git.wordpress.org>
Co-authored-by: talldan <talldanwp@git.wordpress.org>
@ellatrix
Copy link
Member

I just cherry-picked this PR to the wp/6.6-rc-1 branch to get it included in the next release: 41126b1

@ellatrix ellatrix added Backported to WP Core Pull request that has been successfully merged into WP Core and removed Backport to WP 6.6 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta labels Jun 25, 2024
ellatrix pushed a commit that referenced this pull request Jun 25, 2024
Co-authored-by: itzmekhokan <khokansardar@git.wordpress.org>
Co-authored-by: ntsekouras <ntsekouras@git.wordpress.org>
Co-authored-by: talldan <talldanwp@git.wordpress.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backported to WP Core Pull request that has been successfully merged into WP Core [Feature] Document Settings Document settings experience [Type] Bug An existing feature does not function as intended
5 participants