Differential D3862

Fix several lost translations
ClosedPublic
Actions

Authored by nwtour on Apr 16 2021, 6:18 PM.

Details

Reviewers

Freagarach

Commits

rP25282: Fix some translations.

Summary

Idle builder (https://code.wildfiregames.com/D3290):

Add hotkey description for translate

"Other Hotkey" category:

updateTemplates.py does not process the construction translate(markForTranslation()). Split into different lines

Map pager:

Add missing markForTranslation()

Market:

Add missing translate()

Test Plan

Diff Detail

Repository

rP 0 A.D. Public Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

nwtour requested review of this revision.Apr 16 2021, 6:18 PM

nwtour created this revision.

Freagarach added a subscriber: Freagarach.Apr 16 2021, 6:32 PM

Freagarach added inline comments.

binaries/data/mods/public/gui/hotkeys/HotkeyMetadata.js
19 ↗	(On Diff #17130)	Could be part of the prototype, like its category.
binaries/data/mods/public/gui/hotkeys/HotkeysPage.js
122 ↗	(On Diff #17130)	Could be part of the prototype to avoid creating the string even when it is not needed.

Move string to prototype

@Freagarach Updated. Did I get the idea right?

remove Pagination.js (translation not lost - local misscondition)

You certainly got the idea :)

binaries/data/mods/public/gui/hotkeys/HotkeyMetadata.js
69 ↗	(On Diff #17134)	This makes a bit more sense.
binaries/data/mods/public/gui/hotkeys/HotkeysPage.js
124 ↗	(On Diff #17134)
198 ↗	(On Diff #17134)
binaries/data/mods/public/gui/maps/mapbrowser/controls/Pagination.js
38–39 ↗	(On Diff #17134)	These can be moved to the prototype also. :)

change var names

Correct.
Good changes.

If you upload you patches using the webinterface, could you please set the repository next time? That way our linters will run and check your code :)

This revision is now accepted and ready to land.Apr 16 2021, 8:33 PM

In D3862#166998, @Freagarach wrote:

If you upload you patches using the webinterface, could you please set the repository next time? That way our linters will run and check your code :)

Ok. I thought this was just for checking buildable of c ++ code

Closed by commit rP25282: Fix some translations. (authored by Freagarach). · Explain WhyApr 17 2021, 9:47 AM

This revision was automatically updated to reflect the committed changes.

Freagarach added a commit: rP25282: Fix some translations..

Owners added a subscriber: Restricted Owners Package.Apr 17 2021, 9:47 AM