Opened 12 years ago

Closed 12 years ago

Last modified 12 years ago

#1562 closed defect (fixed)

[PATCH] Water interferes with actor viewer rendering

Reported by: historic_bruno Owned by: ben
Priority: Nice to Have Milestone: Alpha 12
Component: Core engine Keywords: patch
Cc: Patch:

Description

The problem is various rendering code uses global variables to determine the simulation's water level (for e.g. culling) and that breaks in actor viewer. It's noticeable as a black space obstructing the view, when the camera moves above the map's water level. The patch fixes this by passing the correct simulation to the renderer before each frame.

As a bonus, I added a water toggle button to actor viewer, so ships can be viewed on a water plane and possibly for nice screenshots.

Attachments (1)

actorviewer_waterfix-07292012.patch​ (16.8 KB ) - added by historic_bruno 12 years ago.

Download all attachments as: .zip

Change History (3)

by historic_bruno, 12 years ago

Attachment: actorviewer_waterfix-07292012.patch​ added

comment:1 by ben, 12 years ago

Owner: set to ben
Resolution: → fixed
Status: new → closed

In 12715:

Fixes actor viewer bug where view was obstructed by map's water level. Fixes #1562.
Adds water plane option to actor viewer.

comment:2 by historic_bruno, 12 years ago

Keywords: review removed
Note: See TracTickets for help on using tickets.