Changeset 27698

Timestamp:

Jun 14, 2023, 9:32:22 AM (14 months ago)

Author:

wraitii

Message:

Speed up AI computation by not using structured clones

Following the AI unthreading in rP26274 / D3769, structured clones are no longer needed to pass the gamestate around.
This is much faster, about 10-15% wall time on an AI 1v1 profile.

This also potentially reduces memory fragmentation and GC needs, as writing clones allocated a lot of data.

Differential Revision: ​https://code.wildfiregames.com/D5019

File:

• ps/trunk/source/simulation2/components/CCmpAIManager.cpp (modified) (6 diffs)

ps/trunk/source/simulation2/components/CCmpAIManager.cpp

@@ -522 +522 @@
     }
 
-    void UpdateGameState(const Script::StructuredClone& gameState)
+    void UpdateGameState( gameState)
     {
         ENSURE(m_CommandsComputed);
-        m_GameState = gameState;
+        m_GameState.reset();
+        m_GameState.init(ScriptRequest(m_ScriptInterface).cx, gameState);
     }
 
@@ -798 +799 @@
         // Deserialize the game state, to pass to the AI's HandleMessage
         ScriptRequest rq(m_ScriptInterface);
-        JS::RootedValue state(rq.cx);
         {
             PROFILE3("AI compute read state");
-            Script::ReadStructuredClone(rq, m_GameState, &state);
-            Script::SetProperty(rq, state, "passabilityMap", m_PassabilityMapVal, true);
-            Script::SetProperty(rq, state, "territoryMap", m_TerritoryMapVal, true);
+            Script::SetProperty(rq, m_GameState, "passabilityMap", m_PassabilityMapVal, true);
+            Script::SetProperty(rq, m_GameState, "territoryMap", m_TerritoryMapVal, true);
         }
 
@@ -816 +815 @@
         {
             PROFILE3("AI run shared component");
-            ScriptFunction::CallVoid(rq, m_SharedAIObj, "onUpdate", state);
+            ScriptFunction::CallVoid(rq, m_SharedAIObj, "onUpdate", tate);
         }
 
@@ -826 +825 @@
 
             if (m_HasSharedComponent && m_Players[i]->m_UseSharedComponent)
-                m_Players[i]->Run(state, m_Players[i]->m_Player, m_SharedAIObj);
+                m_Players[i]->Run(tate, m_Players[i]->m_Player, m_SharedAIObj);
             else
-                m_Players[i]->Run(state, m_Players[i]->m_Player);
+                m_Players[i]->Run(tate, m_Players[i]->m_Player);
         }
     }
@@ -848 +847 @@
     std::set<std::wstring> m_LoadedModules;
 
-    Script::StructuredClone m_GameState;
+    e m_GameState;
     Grid<NavcellData> m_PassabilityMap;
     JS::PersistentRootedValue m_PassabilityMapVal;
@@ -1004 +1003 @@
 
         // Update the game state
-        m_Worker.UpdateGameState(Script::WriteStructuredClone(rq, state));
+        m_Worker.UpdateGameState();
 
         // Update the pathfinding data