Changeset 27674

Timestamp:

Jun 13, 2023, 5:57:18 PM (14 months ago)

Author:

wraitii

Message:

Speed up timer update by using Map.forEach

According to JIT profiling on SM 115, using ForEach is faster than iterating.
This is a micro optimisation, maybe 2% faster for OnUpdate, which means we might see an overall improvement < 0.4%.

The reason this is faster here is that Iterating needs to construct an array to store the result, whereas ForEach just uses the values directly. This means this probably doesn't apply to iterating if we don't need both the key/value pair.

Differential Revision: ​https://code.wildfiregames.com/D5010

File:

• ps/trunk/binaries/data/mods/public/simulation/components/Timer.js (modified) (1 diff)

ps/trunk/binaries/data/mods/public/simulation/components/Timer.js

@@ -115 +115 @@
     // we're in the middle of iterating through it)
     let run = [];
-    for (let [id, timer] of this.timers)
+    
         if (timer.time <= this.time)
             run.push(id);
+
 
     for (let id of run)